Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade pendulum to released version #1434

Merged
merged 2 commits into from
Oct 29, 2023
Merged

downgrade pendulum to released version #1434

merged 2 commits into from
Oct 29, 2023

Conversation

meeuw
Copy link
Contributor

@meeuw meeuw commented Oct 29, 2023

Description

"Unbump" pendulum to released version (3.0.0b1 is a beta version)

requiring 3.0.0b1 gives problems for packing pgcli for Fedora.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@meeuw meeuw requested a review from j-bennet October 29, 2023 19:29
@meeuw
Copy link
Contributor Author

meeuw commented Oct 29, 2023

Related to #1426

@meeuw meeuw force-pushed the downgrade-pendulum branch from b41ba64 to c7ce8d5 Compare October 29, 2023 19:59
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c72820) 79.63% compared to head (c7ce8d5) 79.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files          25       25           
  Lines        3035     3035           
=======================================
  Hits         2417     2417           
  Misses        618      618           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meeuw
Copy link
Contributor Author

meeuw commented Oct 29, 2023

We might advice Python 3.12 users to install pgcli using pip --pre, to allow usage of beta versions?

@j-bennet j-bennet merged commit 08cf5e7 into main Oct 29, 2023
7 checks passed
@j-bennet j-bennet deleted the downgrade-pendulum branch October 29, 2023 23:04
@j-bennet
Copy link
Contributor

Thank you @meeuw .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants