Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running test on python3.12 #1428

Closed
wants to merge 6 commits into from
Closed

running test on python3.12 #1428

wants to merge 6 commits into from

Conversation

laixintao
Copy link
Member

@laixintao laixintao commented Oct 7, 2023

Description

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@laixintao
Copy link
Member Author

laixintao commented Oct 7, 2023

blocked by: pendulum

× Building wheel for pendulum (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [27 lines of output]
      Traceback (most recent call last):
        File "/tmp/pip-install-67wphi0f/pendulum_fd1c8dd3f0fa43d6bda3e881819acc1a/build.py", line 5, in <module>
          from distutils.command.build_ext import build_ext
      ModuleNotFoundError: No module named 'distutils'
  Building wheel for pgcli (pyproject.toml): started
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 251, in build_wheel
          return _build_backend().build_wheel(wheel_directory, config_settings,
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-750mo1w1/overlay/lib/python3.12/site-packages/poetry/core/masonry/api.py", line 57, in build_wheel
          return WheelBuilder.make_in(
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-750mo1w1/overlay/lib/python3.12/site-packages/poetry/core/masonry/builders/wheel.py", line 87, in make_in
          wb.build(target_dir=directory)
        File "/tmp/pip-build-env-750mo1w1/overlay/lib/python3.12/site-packages/poetry/core/masonry/builders/wheel.py", line [122](https://github.com/dbcli/pgcli/actions/runs/6440630220/job/17489629188?pr=1428#step:6:123), in build
          self._build(zip_file)
        File "/tmp/pip-build-env-750mo1w1/overlay/lib/python3.12/site-packages/poetry/core/masonry/builders/wheel.py", line 171, in _build
          self._run_build_script(self._package.build_script)
        File "/tmp/pip-build-env-750mo1w1/overlay/lib/python3.12/site-packages/poetry/core/masonry/builders/wheel.py", line 231, in _run_build_script
          subprocess.check_call([self.executable.as_posix(), build_script])
        File "/opt/hostedtoolcache/Python/3.12.0/x64/lib/python3.12/subprocess.py", line 413, in check_call
          raise CalledProcessError(retcode, cmd)
      subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.12.0/x64/bin/python', 'build.py']' returned non-zero exit status 1.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pendulum

seems pendulum fixed this issue in 3.0+, try to upgrade.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Attention: 237 lines in your changes are missing coverage. Please review.

Comparison is base (6884c29) 84.15% compared to head (6eddbfd) 79.53%.
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
- Coverage   84.15%   79.53%   -4.62%     
==========================================
  Files          21       25       +4     
  Lines        2720     3030     +310     
==========================================
+ Hits         2289     2410     +121     
- Misses        431      620     +189     
Files Coverage Δ
pgcli/__init__.py 100.00% <100.00%> (ø)
pgcli/completion_refresher.py 91.76% <ø> (+1.17%) ⬆️
pgcli/packages/parseutils/__init__.py 100.00% <100.00%> (ø)
pgcli/packages/parseutils/tables.py 97.67% <ø> (ø)
pgcli/packages/prompt_utils.py 70.00% <100.00%> (+5.29%) ⬆️
pgcli/packages/sqlcompletion.py 97.67% <ø> (ø)
pgcli/pgstyle.py 64.00% <ø> (ø)
pgcli/magic.py 0.00% <0.00%> (ø)
pgcli/auth.py 91.30% <91.30%> (ø)
pgcli/key_bindings.py 52.94% <66.66%> (-0.19%) ⬇️
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laixintao laixintao mentioned this pull request Oct 7, 2023
4 tasks
@laixintao
Copy link
Member Author

duplicated #1426

@laixintao laixintao closed this Oct 7, 2023
@laixintao laixintao deleted the py312 branch October 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants