-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run sanitizers on CI #591
Run sanitizers on CI #591
Conversation
33f39c7
to
dbdd891
Compare
04621b1
to
74e3e01
Compare
6e9753d
to
c6957f3
Compare
0bee96d
to
f1b6d98
Compare
fdf1af2
to
784d002
Compare
f30f693
to
523d7df
Compare
#[cfg(not(crossbeam_sanitize))] // TODO: assertions failed due to `cfg(crossbeam_sanitize)` reduce `internal::MAX_OBJECTS` | ||
#[test] | ||
fn incremental() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this test fails when we reduce internal::MAX_OBJECTS
, but it also fails when I run a normal test with --cfg crossbeam_sanitize
. (And, except for cfg(test)
code, cfg(crossbeam_sanitize)
only changes internal::MAX_OBJECTS
.)
$ RUSTFLAGS='--cfg crossbeam_sanitize' cargo test --lib
...
---- collector::tests::incremental stdout ----
thread 'collector::tests::incremental' panicked at 'assertion failed: curr - last <= 1024', crossbeam-epoch/src/collector.rs:227:13
stack backtrace:
0: rust_begin_unwind
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/std/src/panicking.rs:493:5
1: core::panicking::panic_fmt
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/core/src/panicking.rs:92:14
2: core::panicking::panic
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/core/src/panicking.rs:50:5
3: crossbeam_epoch::collector::tests::incremental
at ./src/collector.rs:227:13
4: crossbeam_epoch::collector::tests::incremental::{{closure}}
at ./src/collector.rs:204:5
5: core::ops::function::FnOnce::call_once
at /Users/taiki/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
6: core::ops::function::FnOnce::call_once
at /rustc/80184183ba0a53aa4f491753de9502acd3d6920c/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
collector::tests::incremental
test result: FAILED. 35 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.01s
error: test failed, to rerun pass '--lib'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth reporting in a separate issue. @taiki-e would you please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I've filed #662.
@jeehoonkang Are there any changes that you'd like me to make? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taiki-e LGTM. Please feel free to let bors merge it.
#[cfg(not(crossbeam_sanitize))] // TODO: assertions failed due to `cfg(crossbeam_sanitize)` reduce `internal::MAX_OBJECTS` | ||
#[test] | ||
fn incremental() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth reporting in a separate issue. @taiki-e would you please?
bors r=jeehoonkang |
Build succeeded: |
This adds AddressSanitizer/MemorySanitizer/ThreadSanitizer tests to CI.
See #589 (tsan: data race in deque), #644 (tsan: data race in atomic), and #614 (asan: memory leak in skiplist) for issues reported by sanitizers.
Closes #154
Closes #589
Closes #644
Refs: