-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test i686-unknown-linux-gnu and aarch64-unknown-linux-gnu on CI #613
Conversation
d35d314
to
af6c551
Compare
.github/workflows/ci.yml
Outdated
strategy: | ||
matrix: | ||
crates: | ||
- crossbeam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can maintain only one set of crates for both x86-64 and the cross-target platforms. Maybe later we will add more crates, and I'd wish we should change the CI script in only one place...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. A single 'crates' set is certainly preferable. (It makes a matrix a little more complicated, but it should be possible.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes a matrix a little more complicated, but it should be possible.
Hmm, the way I thought would work didn't really work. I'll look for other ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed this by testing all crates at once in cross tests. (07a1366. The way of adjusting the matrix did not work.)
This should make non-x86-64 platform test time a bit longer than x86-64 platform, at this time. However, eventually, x86-64 platform test will take more time because sanitizers (#591), miri (#578), etc. will be added to x86-64 platform test. So I think this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the revised PR. I just want to suggest another (potential) alternative: can we also test x86-64 platform in cross? If so, we can uniformly treat all platforms using cross.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross doesn't provide images for windows-msvc and darwin, so I don't think using cross on those platforms will no benefit.
However, I'll take a look for a way to merge the test
and cross
jobs into one job.
944f559
to
20c0b41
Compare
20c0b41
to
4ba3e38
Compare
07a1366
to
661e976
Compare
661e976
to
7b6f434
Compare
a1c5b13
to
8796beb
Compare
e83c134
to
a61198b
Compare
85c048b
to
41657a2
Compare
Feature flag can be accidentally enabled by --all-features, so use cfg instead.
41657a2
to
56fb97a
Compare
56fb97a
to
3bdfdef
Compare
@jeehoonkang Updated to test all crates at once.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! I have a few comments.
Thanks! bors r+ |
Build succeeded: |
Tests i686-unknown-linux-gnu and aarch64-unknown-linux-gnu on CI by using cross.
Closes #598
I'm surprised that it looks like we don't have to ignore channel tests.
r? @jeehoonkang