-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Ubuntu container version and MUSL-related libs #452
Conversation
…for section .debug_info' is not happening here as well... bump from stretch to buster to see if mips errors vanish with newer release
Almost there, only one target failing! Weird since this target does have hard float, I think:
|
* Cleanup and bump rust-embedded cross base image from upstream in cross-rs/cross#452 to fix the debug symbols issue observed in #231 * Add test for non-release builds against all features (previously failing because of old toolchain) * Clean all the libs that are already handled via -sys crates. zlib cloudflare must be fixed upstream, not here. Only LLVM is needed at this point via docker, the (broken) htslib Makefile to build.rs transition that @pmarks did, simplified all this significantly, kudos
…es for qemu: https://dev.azure.com/rust-embedded/cross/_build/results?buildId=683&view=logs&j=14306e81-fbe4-59fd-bc5f-032f2af5fc08&t=2a05b173-dace-5b05-398f-3302c91762f2&l=6240 ... hopefully nothing times out this time around and all is green?
bors r+ |
🔒 Permission denied Existing reviewers: click here to make brainstorm a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine (and needed), but I'm not sure about consequences.
Thanks @Emilgardis 👍🏻 Does any of the reviewers fear that something is going to break or similar side effects? The changes are not so many IMHO :-S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this.
bors r+
Build succeeded: |
Several reasons, including but not limited to: