Slim docker musl #233
Merged
Slim docker musl #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via a fork in FiloSottile/homebrew-musl-cross#13 (comment), so now it's fast to install (just a bottle pour) :)
…s-rs/cross#452 to fix the debug symbols issue observed in #231
…ing because of old toolchain)
…udflare must be fixed upstream, not here. Only LLVM is needed at this point via docker, the (broken) htslib Makefile to build.rs transition that @pmarks did, simplified all this significantly, kudos
|
@brainstorm Can the |
|
@juliangehring Two different beasts: To your question: yes, Other than that, I think this PR is good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the debugging issues (non
--releasebuilds breaking because of compressed debug symbols).... as observed in #231.Also general cleanup, reducing final docker image size. Further cleanups expected if cross-rs/cross#452 passes and gets merged in, otherwise we'll be using
brainstorm/cross-x86_64-unknown-linux-musl:upstreamfor now.The cloudflare speedups on zlib will have to wait until rust-lang/libz-sys#63 (comment) gets approved/repointed.... I'll experiment with this crate in a separate PR:https://crates.io/crates/cloudflare-zlib-sys