Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessarily dangerous -DOPENSSL_NO_SECURE_MEMORY #3

Closed
brainstorm opened this issue May 20, 2020 · 4 comments
Closed

Unnecessarily dangerous -DOPENSSL_NO_SECURE_MEMORY #3

brainstorm opened this issue May 20, 2020 · 4 comments

Comments

@brainstorm
Copy link

Please see the following for a docker container that does not require that feature to be disabled on OpenSSL 1.1.1g:

https://github.com/brainstorm/rust-htslib/blob/musl_support/docker/Dockerfile.musl
@brainstorm
Copy link
Author

... and while I'm here, could you add bzip2 to your great rust-static-builder mix too, pleease? It just takes a:

RUN git clone git://sourceware.org/git/bzip2 \
    && cd bzip2 \
    && make PREFIX=/usr/local/musl bzip2 \
    && make install

:)

@fornwall
Copy link
Owner

fornwall commented Jun 3, 2020

Thanks! I've added bzip2 now, need to look into https://github.com/GregorR/musl-cross for to avoid -DOPENSSL_NO_SECURE_MEMORY.

@brainstorm
Copy link
Author

brainstorm commented Jun 3, 2020 •
edited
Loading

Thanks! You should perhaps also add it on the README? Also, I believe that my container referred above already avoids having to define that flag? IIRC, upgrading to MUSL 1.2.0 did the trick for me when compiling OpenSSL 1.1.1f.

@fornwall
Copy link
Owner

fornwall commented Jun 3, 2020

Thanks, added it to the README in 96fa10d

@brainstorm brainstorm mentioned this issue Aug 12, 2020
Merged
bors bot added a commit to cross-rs/cross that referenced this issue Sep 3, 2020
@bors @brainstorm
Merge #452
699f07a 
452: Bump Ubuntu container version and MUSL-related libs r=therealprof a=brainstorm

Several reasons, including but not limited to:

1) MUSL-compiled OpenSSL benefits from MUSL versions 1.2.0 and up, otherwise it needs to be badly patched, see fornwall/rust-static-builder#3 (comment).
2) DWARFv2 compressed debugging symbols mess up with old toolchains and linkers, see rust-bio/rust-htslib#231.

Co-authored-by: Roman Valls Guimera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brainstorm @fornwall