-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump go version in all go mods #6185
Conversation
* add generation of pulsar files * remove wrong import * remove code that should come in a different PR * update pulsar files * api go mod tidy * chore: consolidate protogen scripts * proto: add override to buf.gen.pulsar for cosmos-sdk * chore: go mod tidy api * proto: use protobuf/types/known/anypb * chore: tidy api mod. * proto: rm go-grpc plugin for pulsar * chore: go mod tidy api * github: add workflow to at least sanity check that api mod builds on modifications. * wip: add opt for ics23, rebuild pulsar. Comment out imports for time being. * deps: replace with go psuedoversion of pulsar ics23 temp branch * Update api/go.mod --------- Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: DimitrisJim <[email protected]>
Important Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
couple of places I tried to outline here #5776 (which this PR should fully close, hopefully) |
@damiannolan Thank you for opening the PR. Downgrading the api module of both ics23 and ibc-go to use go 1.21 makes the trick of building the depinject PRs (see #5976). So for now we are not blocked on the upgrade to go 1.22. |
Will close this PR for now. Can be reopened or redone on main as needed |
Superseded by #6380 |
Description
Bump the go versions in each go module.
I think this may require some doc updates in places. Unsure if its needed until release tho!
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.