Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump go version in all go mods #6185

Closed
wants to merge 6 commits into from
Closed

Conversation

damiannolan
Copy link
Member

Description

Bump the go versions in each go module.

I think this may require some doc updates in places. Unsure if its needed until release tho!


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Carlos Rodriguez and others added 2 commits April 18, 2024 11:57
* add generation of pulsar files

* remove wrong import

* remove code that should come in a different PR

* update pulsar files

* api go mod tidy

* chore: consolidate protogen scripts

* proto: add override to buf.gen.pulsar for cosmos-sdk

* chore: go mod tidy api

* proto: use protobuf/types/known/anypb

* chore: tidy api mod.

* proto: rm go-grpc plugin for pulsar

* chore: go mod tidy api

* github: add workflow to at least sanity check that api mod builds on modifications.

* wip: add opt for ics23, rebuild pulsar. Comment out imports for time being.

* deps: replace with go psuedoversion of pulsar ics23 temp branch

* Update api/go.mod

---------

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: DimitrisJim <[email protected]>
Copy link
Contributor

coderabbitai bot commented Apr 18, 2024

Important

Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@DimitrisJim
Copy link
Contributor

couple of places I tried to outline here #5776 (which this PR should fully close, hopefully)

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Apr 18, 2024

@damiannolan Thank you for opening the PR. Downgrading the api module of both ics23 and ibc-go to use go 1.21 makes the trick of building the depinject PRs (see #5976). So for now we are not blocked on the upgrade to go 1.22.

@damiannolan
Copy link
Member Author

Will close this PR for now. Can be reopened or redone on main as needed

@crodriguezvega crodriguezvega changed the base branch from feat/depinject to main May 24, 2024 09:13
@crodriguezvega crodriguezvega mentioned this pull request May 24, 2024
10 tasks
@crodriguezvega
Copy link
Contributor

Superseded by #6380

@damiannolan damiannolan deleted the damian/bump-go-versions branch June 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants