deps: bump go 1.22 #6380
deps: bump go 1.22 #6380
Conversation
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan,
srdtrk,
chatton,
charleenfei and
DimitrisJim
as code owners
WalkthroughWalkthroughThe changes primarily involve updating the Go version from Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
|
||
| toolchain go1.21.0 | ||
| toolchain go1.22.0 |
There was a problem hiding this comment.
any idea if this is needed? some files have it, some not 🤷
There was a problem hiding this comment.
Probably it's not. Since it was already there, I left it...
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (16)
Dockerfile (3)
Line range hint
13-16: PreferCOPYoverADDfor copying local files asCOPYis more transparent.- ADD internal internal - ADD testing testing - ADD modules modules - ADD LICENSE LICENSE + COPY internal internal + COPY testing testing + COPY modules modules + COPY LICENSE LICENSE
Line range hint
18-22: EnsureWORKDIRis set before copying files to a relative destination to avoid ambiguity.+ WORKDIR /go COPY contrib/devtools/Makefile contrib/devtools/Makefile COPY Makefile . COPY go.mod . COPY go.sum .
Line range hint
26-26: Consider consolidating multipleRUNinstructions to reduce layers and improve build efficiency.- RUN go mod download - RUN make build + RUN go mod download && make buildmodules/apps/callbacks/Dockerfile (4)
Line range hint
9-12: PreferCOPYoverADDfor copying local files asCOPYis more transparent.- ADD internal internal - ADD testing testing - ADD modules modules - ADD LICENSE LICENSE + COPY internal internal + COPY testing testing + COPY modules modules + COPY LICENSE LICENSE
Line range hint
14-15: EnsureWORKDIRis set before copying files to a relative destination to avoid ambiguity.+ WORKDIR /go/modules/apps/callbacks COPY go.mod . COPY go.sum .
Line range hint
17-17: Use an absolute path forWORKDIRto avoid potential issues with relative paths.- WORKDIR modules/apps/callbacks + WORKDIR /go/modules/apps/callbacks
Line range hint
21-21: Consider consolidating multipleRUNinstructions to reduce layers and improve build efficiency.- RUN go mod download - RUN GOOS=linux GOARCH=amd64 LEDGER_ENABLED=false go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version= -X github.com/cosmos/cosmos-sdk/version.Commit= -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo ledger," -w -s' -trimpath -o /go/build/ ./... + RUN go mod download && \ + GOOS=linux GOARCH=amd64 LEDGER_ENABLED=false go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version= -X github.com/cosmos/cosmos-sdk/version.Commit= -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo ledger," -w -s' -trimpath -o /go/build/ ./...modules/light-clients/08-wasm/Dockerfile (6)
Line range hint
7-7: Consolidate multipleRUNinstructions to reduce layers and improve build efficiency.- RUN test -n "${LIBWASM_VERSION}" - RUN test -n "${LIBWASM_CHECKSUM}" + RUN test -n "${LIBWASM_VERSION}" && test -n "${LIBWASM_CHECKSUM}"
Line range hint
9-9: Pin specific versions of packages inapk addto ensure reproducibility.- RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make; + RUN set -eux; apk add --no-cache git=2.30.2-r0 libusb-dev=1.0.24-r1 linux-headers=5.10.41-r0 gcc=10.3.1_git20210424-r2 musl-dev=1.2.2-r3 make=4.3-r0;
Line range hint
15-15: Set theSHELLoption-o pipefailbefore using a pipe inRUNto ensure that errors in a pipeline are not masked.+ SHELL ["/bin/ash", "-eo", "pipefail"] RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep ${LIBWASM_CHECKSUM}
Line range hint
20-23: PreferCOPYoverADDfor copying local files asCOPYis more transparent.- ADD internal internal - ADD testing testing - ADD modules modules - ADD LICENSE LICENSE + COPY internal internal + COPY testing testing + COPY modules modules + COPY LICENSE LICENSE
Line range hint
25-26: EnsureWORKDIRis set before copying files to a relative destination to avoid ambiguity.+ WORKDIR /go/modules/light-clients/08-wasm COPY go.mod . COPY go.sum .
Line range hint
32-32: Consider consolidating multipleRUNinstructions to reduce layers and improve build efficiency.- RUN go mod download - RUN GOOS=linux GOARCH=amd64 go build -mod=readonly -tags "netgo ledger muslc" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version= -X github.com/cosmos/cosmos-sdk/version.Commit= -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo ledger muslc," -w -s -linkmode=external -extldflags "-Wl,-z,muldefs -static"' -trimpath -o /go/build/ ./... + RUN go mod download && \ + GOOS=linux GOARCH=amd64 go build -mod=readonly -tags "netgo ledger muslc" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version= -X github.com/cosmos/cosmos-sdk/version.Commit= -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo ledger muslc," -w -s -linkmode=external -extldflags "-Wl,-z,muldefs -static"' -trimpath -o /go/build/ ./...CHANGELOG.md (3)
Line range hint
216-216: Remove trailing spaces.- * [\#6380](https://github.com/cosmos/ibc-go/pull/6380) Bump go to v1.22. + * [\#6380](https://github.com/cosmos/ibc-go/pull/6380) Bump go to v1.22.
Line range hint
266-266: Remove trailing spaces.- * [\#6380](https://github.com/cosmos/ibc-go/pull/6380) Bump go to v1.22. + * [\#6380](https://github.com/cosmos/ibc-go/pull/6380) Bump go to v1.22.
Line range hint
201-201: Use a descriptive text for URLs to improve accessibility.- * [\#6380](https://github.com/cosmos/ibc-go/pull/6380) Bump go to v1.22. + * [\#6380](Bump go to v1.22)[https://github.com/cosmos/ibc-go/pull/6380]
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (5)
e2e/go.modis excluded by!**/*.mod,!**/*.modgo.modis excluded by!**/*.mod,!**/*.modmodules/apps/callbacks/go.modis excluded by!**/*.mod,!**/*.modmodules/capability/go.modis excluded by!**/*.mod,!**/*.modmodules/light-clients/08-wasm/go.modis excluded by!**/*.mod,!**/*.mod
Files selected for processing (18)
- .github/workflows/callbacks.yml (3 hunks)
- .github/workflows/capability.yml (2 hunks)
- .github/workflows/e2e-compatibility-workflow-call.yaml (1 hunks)
- .github/workflows/e2e-fork.yml (4 hunks)
- .github/workflows/e2e-test-workflow-call.yml (2 hunks)
- .github/workflows/e2e-wasm.yaml (1 hunks)
- .github/workflows/e2e.yaml (1 hunks)
- .github/workflows/e2emodule.yml (2 hunks)
- .github/workflows/golangci-feature.yml (1 hunks)
- .github/workflows/golangci.yml (1 hunks)
- .github/workflows/release.yml (1 hunks)
- .github/workflows/test.yml (2 hunks)
- .github/workflows/wasm-client.yml (3 hunks)
- CHANGELOG.md (1 hunks)
- Dockerfile (1 hunks)
- go.work.example (1 hunks)
- modules/apps/callbacks/Dockerfile (1 hunks)
- modules/light-clients/08-wasm/Dockerfile (1 hunks)
Files skipped from review due to trivial changes (13)
- .github/workflows/callbacks.yml
- .github/workflows/e2e-compatibility-workflow-call.yaml
- .github/workflows/e2e-fork.yml
- .github/workflows/e2e-test-workflow-call.yml
- .github/workflows/e2e-wasm.yaml
- .github/workflows/e2e.yaml
- .github/workflows/e2emodule.yml
- .github/workflows/golangci-feature.yml
- .github/workflows/golangci.yml
- .github/workflows/release.yml
- .github/workflows/test.yml
- .github/workflows/wasm-client.yml
- go.work.example
Additional Context Used
Markdownlint (3)
CHANGELOG.md (3)
216: Expected: 0 or 2; Actual: 1
Trailing spaces
266: Expected: 0 or 2; Actual: 1
Trailing spaces
201: null
Bare URL used
Hadolint (29)
Dockerfile (10)
4: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
13: Use COPY instead of ADD for files and folders
14: Use COPY instead of ADD for files and folders
15: Use COPY instead of ADD for files and folders
16: Use COPY instead of ADD for files and folders
18:
COPYto a relative destination withoutWORKDIRset.
19:
COPYto a relative destination withoutWORKDIRset.
21:
COPYto a relative destination withoutWORKDIRset.
22:
COPYto a relative destination withoutWORKDIRset.
26: Multiple consecutive
RUNinstructions. Consider consolidation.modules/apps/callbacks/Dockerfile (9)
3: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
9: Use COPY instead of ADD for files and folders
10: Use COPY instead of ADD for files and folders
11: Use COPY instead of ADD for files and folders
12: Use COPY instead of ADD for files and folders
14:
COPYto a relative destination withoutWORKDIRset.
15:
COPYto a relative destination withoutWORKDIRset.
17: Use absolute WORKDIR
21: Multiple consecutive
RUNinstructions. Consider consolidation.modules/light-clients/08-wasm/Dockerfile (10)
7: Multiple consecutive
RUNinstructions. Consider consolidation.
9: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
15: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
20: Use COPY instead of ADD for files and folders
21: Use COPY instead of ADD for files and folders
22: Use COPY instead of ADD for files and folders
23: Use COPY instead of ADD for files and folders
25:
COPYto a relative destination withoutWORKDIRset.
26:
COPYto a relative destination withoutWORKDIRset.
32: Multiple consecutive
RUNinstructions. Consider consolidation.
Path-based Instructions (1)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Additional comments not posted (4)
Dockerfile (1)
1-1: Update to Go 1.22 and Alpine 3.20 is aligned with the PR objectives.modules/apps/callbacks/Dockerfile (1)
1-1: Update to Go 1.22 and Alpine 3.20 is aligned with the PR objectives.modules/light-clients/08-wasm/Dockerfile (1)
1-1: Update to Go 1.22 and Alpine 3.20 is aligned with the PR objectives..github/workflows/capability.yml (1)
20-20: Update to Go 1.22 in GitHub Actions workflow is aligned with the PR objectives.Also applies to: 32-32
| @@ -41,6 +41,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * [\#6193](https://github.com/cosmos/ibc-go/pull/6193) Bump Cosmos SDK to v0.50.6. | |||
| * [\#6193](https://github.com/cosmos/ibc-go/pull/6193) Bump `cosmossdk.io/store` to v1.1.0. | |||
| * [\#6239](https://github.com/cosmos/ibc-go/pull/6239) Bump CometBFT to v0.38.7. | |||
| * [\#6380](https://github.com/cosmos/ibc-go/pull/6380) Bump go to v1.22. | |||
There was a problem hiding this comment.
Ensure the Go version update is documented in the changelog.
Please add an entry in the changelog under the "Dependencies" section to document the update of the Go version to 1.22 as part of this pull request.
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.21-alpine3.18 as builder | |||
| FROM golang:1.22-alpine3.20 as builder | |||
| ARG IBC_GO_VERSION | |||
|
|
|||
| RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make; | |||
There was a problem hiding this comment.
Pin specific versions of packages in apk add to ensure reproducibility.
- RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make;
+ RUN set -eux; apk add --no-cache git=2.30.2-r0 libusb-dev=1.0.24-r1 linux-headers=5.10.41-r0 gcc=10.3.1_git20210424-r2 musl-dev=1.2.2-r3 make=4.3-r0;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make; | |
| RUN set -eux; apk add --no-cache git=2.30.2-r0 libusb-dev=1.0.24-r1 linux-headers=5.10.41-r0 gcc=10.3.1_git20210424-r2 musl-dev=1.2.2-r3 make=4.3-r0; |
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.21-alpine3.18 as builder | |||
| FROM golang:1.22-alpine3.20 as builder | |||
|
|
|||
| RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make; | |||
There was a problem hiding this comment.
Pin specific versions of packages in apk add to ensure reproducibility.
- RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make;
+ RUN set -eux; apk add --no-cache git=2.30.2-r0 libusb-dev=1.0.24-r1 linux-headers=5.10.41-r0 gcc=10.3.1_git20210424-r2 musl-dev=1.2.2-r3 make=4.3-r0;Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make; | |
| RUN set -eux; apk add --no-cache git=2.30.2-r0 libusb-dev=1.0.24-r1 linux-headers=5.10.41-r0 gcc=10.3.1_git20210424-r2 musl-dev=1.2.2-r3 make=4.3-r0; |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/callbacks.yml (3 hunks)
- .github/workflows/capability.yml (2 hunks)
- .github/workflows/test.yml (3 hunks)
- .github/workflows/wasm-client.yml (3 hunks)
- CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (4)
- .github/workflows/callbacks.yml
- .github/workflows/capability.yml
- .github/workflows/test.yml
- .github/workflows/wasm-client.yml
Additional Context Used
Markdownlint (4)
CHANGELOG.md (4)
57: Expected: 0 or 2; Actual: 1
Trailing spaces
217: Expected: 0 or 2; Actual: 1
Trailing spaces
267: Expected: 0 or 2; Actual: 1
Trailing spaces
202: null
Bare URL used
Path-based Instructions (1)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Additional comments not posted (1)
CHANGELOG.md (1)
44-44: The changelog entry for the Go version bump to 1.22 is correctly documented.
|
Description
I shamelessly took @damiannolan's changes from the depinject feature branch and applied them to main.
Tested locally both
make proto-allandmake test.closes: #5776
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.Summary by CodeRabbit