Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ics29 fee GenesisState to include multiple fees #955

Closed
3 tasks
damiannolan opened this issue Feb 21, 2022 · 0 comments
Closed
3 tasks

Update ics29 fee GenesisState to include multiple fees #955

damiannolan opened this issue Feb 21, 2022 · 0 comments
Assignees
Labels

Comments

@damiannolan
Copy link
Member

Summary

Update ics29-fee GenesisState to include new type repeated IncentivizedPacketFees in favour of repeated IncentivizedPacketFee (singular). This is a follow-up task in ref. to #760 and #761


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan self-assigned this Feb 21, 2022
@damiannolan damiannolan moved this to In progress in ibc-go Feb 21, 2022
@damiannolan damiannolan moved this from In progress to In review in ibc-go Feb 22, 2022
Repository owner moved this from In review to Done in ibc-go Feb 23, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
…os#955)

Since cosmos-sdk release/v0.45.x and release/0.46.x only depend on
cometbft v0.34.x, i have pushed a branch v0.34.x to
https://github.com/rollkit/cometbft/tree/v0.34.x and applied the fraud
proof changes from rollkit/tendermint. This PR is simply replacing the
`github.com/tendermint/tendermint` with `github.com/rollkit/cometbft
v0.0.0-20230523181933-31b0a76c97d9` which corresponds to latest commit
from https://github.com/rollkit/cometbft/tree/v0.34.x.

This builds without any issues, however some tests are failing and needs
to be fixed.

After this, we can release rollkit with this cometbft change and sync
our cosmos-sdk forks (release/v0.45.x and release/v0.46.x) and also add
the newly released rollkit (w/ cometbft).

rollkit/rollkit#793 PR and
https://github.com/rollkit/cometbft/tree/rollkit/v0.37.0 is still needed
when we add support for cosmos-sdk release/v0.47.x, which uses module
`github.com/cometbft/cometbft` path and not
`github.com/tendermint/tendermint`

---------

Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant