Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Fee storage more efficient #760

Closed
AdityaSripal opened this issue Jan 18, 2022 · 0 comments
Closed

Make Fee storage more efficient #760

AdityaSripal opened this issue Jan 18, 2022 · 0 comments
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@AdityaSripal
Copy link
Member

Currently the FeeInEscrow mapping in the fee store contains the PacketID in both the key and the marshalled value. This is wasted storage that we should remove from state.

IdentifiedPacketFee should still exist for users and genesis for UX, it just shouldn't be stored directly in state.
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 18, 2022
@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@damiannolan damiannolan mentioned this issue Feb 12, 2022
Merged
9 tasks
@damiannolan damiannolan self-assigned this Feb 19, 2022
@damiannolan damiannolan moved this from Backlog to Todo in ibc-go Feb 19, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 19, 2022
This was referenced Feb 21, 2022
Merged
Closed
Closed
Merged
Merged
@damiannolan damiannolan moved this from In progress to In review in ibc-go Feb 22, 2022
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Merge pull request cosmos#760 from CosmWasm/749-client-encoding
95d58b8 
Replace custom codec with sdk codec
Repository owner moved this from In review to Done in ibc-go Feb 23, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@S1nus
Lazy Sequencer (cosmos#760)
58681cc 
Co-authored-by: Connor O'Hara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
3 participants
@damiannolan @seantking @AdityaSripal