Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple addresses to incentivize a packet #761

Closed
AdityaSripal opened this issue Jan 18, 2022 · 4 comments
Closed

Allow multiple addresses to incentivize a packet #761

AdityaSripal opened this issue Jan 18, 2022 · 4 comments
Assignees
Labels

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Jan 18, 2022

  • Include the refund address in the key of the stored fee. packetID + refund_addr -> accumulated fees escrowed by this sender for this packetID + relayer list
  • On distribution, loop through all fees stored for a given packetID and execute the distribution logic with the same relayers for each refund address.
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 18, 2022
@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Jan 24, 2022
@crodriguezvega crodriguezvega assigned seantking and unassigned seantking Feb 7, 2022
@colin-axner colin-axner self-assigned this Feb 9, 2022
@colin-axner
Copy link
Contributor

colin-axner commented Feb 9, 2022

What happens if the same funder tries to incentivize a packet but specifies a different relayer list?

If we wanted to allow this, we should be mapping to a slice of identified packet fees, but then I'm wondering why we don't just map from packetID -> []identified packet fee (with refund address)

Was there a security concern with not including the refund address in the key?

@colin-axner
Copy link
Contributor

Do we want the refund addr in the key or identified fee struct? It shouldn't be both. It is convenient for it to be in the mapping, but you can filter based on incentivizer if it is in the key

@AdityaSripal
Copy link
Member Author

I think the map from packetID -> []identified packet fee (with refund address) solution makes the most sense

I don't think it's that important to additionally key on refund address, especially if the first prefix is packetID

@colin-axner colin-axner removed their assignment Feb 9, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Feb 14, 2022
@damiannolan damiannolan self-assigned this Feb 21, 2022
@damiannolan
Copy link
Member

closed by #915

Repository owner moved this from In progress to Done in ibc-go Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants