-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SDK dependency injection for v2 apps #3560
Comments
Thank you, @alpe, for opening this issue. How pressing is your need to have ibc-go compatible with app v2? Having also app v1 is blocking any urges development on your side? |
The v1 app is working with our sdk v47 integration. But as v2 had become the "preferred" setup (in build tags) we were eager to provide a fully compatible module with our official release. |
Thanks for the information, @alpe. What is your timeline for v0.41? And If I understand correctly, then you would like to have this available in the v7 release line, right? |
v7.x would be nice to have a small change set only. In CosmWasm/wasmd#1287 we have a mixed v2 with v1 legacy module setup in /app. That could be some template for your test setup before adding full v2 support to the module. |
All the branches to add support to a module will need to branch off carlos/add-buf-gen-pulsar (at least until this branch is merged into feat/depinject). Do we need also to add support in the mock module? |
Summary
SDK 47 ships with the new dependency-injection framework used in app_v2.
As wasmd has a dependency to the ibc (core and other) keepers, we can not update our module to be used with the dependency-injection framework.
There is no workaround AFAIK
Proposal
Please make the modules compatible to work with app v1 + v2.
For Admin Use
The text was updated successfully, but these errors were encountered: