Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SDK dependency injection for v2 apps #3560

Open
3 tasks
alpe opened this issue May 4, 2023 · 5 comments
Open
3 tasks

Support SDK dependency injection for v2 apps #3560

alpe opened this issue May 4, 2023 · 5 comments
Assignees
Labels
type: feature New features, sub-features or integrations
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented May 4, 2023

Summary

SDK 47 ships with the new dependency-injection framework used in app_v2.

As wasmd has a dependency to the ibc (core and other) keepers, we can not update our module to be used with the dependency-injection framework.
There is no workaround AFAIK

Proposal

Please make the modules compatible to work with app v1 + v2.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

Thank you, @alpe, for opening this issue. How pressing is your need to have ibc-go compatible with app v2? Having also app v1 is blocking any urges development on your side?

@alpe
Copy link
Contributor Author

alpe commented May 15, 2023

The v1 app is working with our sdk v47 integration. But as v2 had become the "preferred" setup (in build tags) we were eager to provide a fully compatible module with our official release.
This is not possible due to our dependency on ibc-go in the wasmd module. We set the new goal for v2 support in the v0.41 release.
Therefore it is not super urgent but blocking the integration work on our side.

@crodriguezvega
Copy link
Contributor

Thanks for the information, @alpe. What is your timeline for v0.41?

And If I understand correctly, then you would like to have this available in the v7 release line, right?

@alpe
Copy link
Contributor Author

alpe commented May 19, 2023

v7.x would be nice to have a small change set only.
We don't have a strict release schedule for v0.41 but target middle of April. As the work on our side had started already, it would be great to not have this pending for too long.

In CosmWasm/wasmd#1287 we have a mixed v2 with v1 legacy module setup in /app. That could be some template for your test setup before adding full v2 support to the module.

@crodriguezvega crodriguezvega linked a pull request Jun 16, 2023 that will close this issue
9 tasks
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Jun 26, 2023
@crodriguezvega crodriguezvega self-assigned this Jun 26, 2023
@crodriguezvega crodriguezvega moved this from In progress 👷 to Todo 🏃 in ibc-go Feb 13, 2024
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Mar 4, 2024

All the branches to add support to a module will need to branch off carlos/add-buf-gen-pulsar (at least until this branch is merged into feat/depinject).

Do we need also to add support in the mock module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New features, sub-features or integrations
Projects
Status: On hold ❌
Development

Successfully merging a pull request may close this issue.

4 participants