feat(depinject): add support for core #4040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
June 16, 2023 11:13
…-for-v2-apps # Conflicts: # modules/core/module.go
…-dependency-injection-for-v2-apps # Conflicts: # proto/ibc/core/module/v1/module.proto
…-dependency-injection-for-v2-apps # Conflicts: # go.mod
…-dependency-injection-for-v2-apps
…upport-code # Conflicts: # go.mod # modules/core/module.go
crodriguezvega
changed the title
…upport-code # Conflicts: # e2e/go.mod # go.mod # go.sum # modules/core/module.go
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## carlos/add-buf-gen-pulsar #4040 +/- ##
=============================================================
- Coverage 79.49% 79.39% -0.11%
=============================================================
Files 189 189
Lines 13285 13307 +22
=============================================================
+ Hits 10561 10565 +4
- Misses 2296 2314 +18
Partials 428 428
|
|
Closing for now, but will keep the branch, so that I can pick it up again later on. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the necessary machinery to configure core module with dependency injection. It needs #4039.
ref: #3560
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.