Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy up imported packages orders #1527

Closed
5 tasks
yaruwangway opened this issue Jun 7, 2022 · 5 comments
Closed
5 tasks

tidy up imported packages orders #1527

yaruwangway opened this issue Jun 7, 2022 · 5 comments

Comments

@yaruwangway
Copy link
Contributor

yaruwangway commented Jun 7, 2022 •
edited
Loading

Summary

tidy the imported packages order:

import (
stdlib

cosmos-sdk/tendermint/ibc others

gaia lib
)

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@mmulji-ic mmulji-ic mentioned this issue Jun 27, 2022
Closed
50 tasks
@Anmol1696
Copy link
Contributor

Can to take this up, if this is still needed for rho upgrade.

@yaruwangway
Copy link
Contributor Author

feel free ! Thank you ! @Anmol1696 👍

@mmulji-ic
Copy link
Contributor

@Anmol1696 do you want to run with this?

@okwme
Copy link
Contributor

okwme commented Aug 15, 2022

hey @Anmol1696 is this included in #1580

@Anmol1696
Copy link
Contributor

Anmol1696 commented Aug 17, 2022 •
edited
Loading

Ahh sorry missed out on the thread, can add this to #1580 as well if you guys want, but i will raise another PR today for this

Anmol1696 added a commit to Anmol1696/gaia that referenced this issue Aug 17, 2022
@Anmol1696
Tidy up imports as per cosmos#1527
cf42799
@Anmol1696 Anmol1696 mentioned this issue Aug 17, 2022
Closed
@faddat faddat mentioned this issue Aug 25, 2022
Merged
okwme pushed a commit that referenced this issue Sep 14, 2022
@faddat @Anmol1696
Make format (#1694)
6430d6f 
* Tidy up imports as per #1527

* make format and update make format in makefile

* merge Anmol's work then run make format agasinst it

Co-authored-by: Anmol1696 <[email protected]>
@okwme okwme closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@okwme @Anmol1696 @yaruwangway @mmulji-ic