CheckList for rho release

[yaruwangway]

Summary

contributors please add the issues for rho here for a final check before going to testnet and release.

Here is a check list for rho code (continuing updating):

• Rosetta API
  • add tests for rosetta api, and its data correctness.
  • Incorporate the rosetta cli #1529
  • /cosmos/tx/v1beta1/txs/ counldn't show the transaction is failed with relevant raw log.  #1618
  • Balance incorrect when querying address.  #1518
• Global Fee Module
  • docs for global fee (yaru)
  • unit tests for global fee (yaru)
  • add failure tests for global fee (yaru)
  • add e2e test for setting up globalfee by gov proposal changing params and test the fee is valid (yaru)
  • e2e test for bypass min fee (yaru)
  • check fee not enough err log, should be insufficient fee rather than panic panic: value method github.com/cosmos/cosmos-sdk/types.TxResponse.UnpackInterfaces called using nil *TxResponse pointer insufficient fees err log for gaia rho branch (main) #1534 (yaru)
  • bypass min fee config order issue Config app.toml param bypass-min-fee-msg-types not work #1486
  • check and test all the fee checks can bypass configured types of txs (yaru)
  • test ica from gov in e2e test
• upgrade handler (Lauren)
• Hermes
  • confirm hermes config gas-price is working with global fee changes, test results
• ICA module
  • docs for ica auth (Lauren)
  • change whitelist of the ica host allowed msg types to blacklist of blocked msg types? discussion: Whitelist all msg types in ica? #1498
  • add /ibc.applications.transfer.v1.MsgTransfer to ica host allowed msg types. check if the whitelist of allowed smg types change to blacklist not allowed msg types.
• GOV module
  • clean up e2e test, comments, change govproposals fn not hardcoded.
  • refator ssubmitLegacyProposalFundGovAccount to submitLegacyProposal
• Group module
  • Additional e2e test coverage for Groups module
• Packet Forwarding
  • Packet forward middleware doesn't work #1441
  • add tests for packet-forward-middleware.
• Miscellaneous
  • go version 1.18 (yaru)
  • check gaiad tendermint unsafe-reset-all working
  • Remove --mode validator flag" for the SDK #1553
  • check replace dependencies are replaced back to released version ibc, tm-db (yaru)
  • refactor: rename all const.go alias.go or the other way rename all alias.go const.go
  • Rho: clean gaia/app #1557
  • Tidy up imported packages orders #1527
  • make targets missing or fail #1489
  • <!-- markdown-link-check-disable-next-line --> will generate an extra space, remove space
  • contrib/scripts/protogen.sh -> proto/scripts/protogen_globalfee.sh
  • add e2e test for minor versions compatibility test (optional for rho major release)
  • test security issues
  • rename NewBypassMinFeeDecorator to FeeDecorator
  • update third_party proto dependencies to use buf registry

Problem Definition

Proposal

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?

[mpoke]

@yaruwangway Could you please asses the relevance of this issue given that the scope of the Rho release was changed?

[yaruwangway]

Hi, this can be closed, I will just open an issue about rosetta api