Make format #1694
Merged
Make format #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
okwme,
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
cmwaters,
jackzampolin,
mmulji-ic and
glnro
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1694 +/- ##
=======================================
Coverage 51.60% 51.60%
=======================================
Files 13 13
Lines 1682 1682
=======================================
Hits 868 868
Misses 788 788
Partials 26 26 |
Closed
|
Awesome I'm glad that it put together the two techniques that we were chasing. Really happy to see another hub contributor 🙂 |
|
Please let me know if this is desired. |
okwme
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our command
make formatso that it matches ibc-go and the cosmos-sdk.make formatwill now fungofumpt -w -landgolangci-lint run ./... --fixIt also pulls in a solution to #1527 from @Anmol1696 because we actually changed the ibc-go Makefile (and then the cosmos-sdk Makefile) while working on similar import grouping / code consistency questions.
(basically I figured they might as well go in the same PR)