feat: secp256k1 public key constant time #18026

bizk · 2023-10-09T22:24:22Z

Description

Closes: #7051

This PR replaces public key generation on secp256k1 keys from dcrd library which is non constant to another implementation that it is.

It tests legacy code and the newest key generation, also adds tests and benchmarks

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Summary by CodeRabbit

New Features
- Implemented constant time public key generation for secp256k1, enhancing security.
Bug Fixes
- Resolved issue secp256k1: Not constant time #7051 related to public key generation timing.
Documentation
- Updated CHANGELOG with recent improvements and fixes.
Refactor
- Improved Info struct with additional ExtraInfo field.
- Enhanced parsing of chain-id from the genesis file using a streaming JSON parser.
Tests
- Added new test functions to ensure constant time public key generation.
- Updated integration tests to use require assertions for better readability.
Chores
- Streamlined proto dependencies exportation with buf export command.

Please note that these release notes are a high-level summary and do not include internal code-level details to maintain confidentiality.

…re/schnorr-1

…re/schnorr-2

…ure/schnorr-2

…re/schnorr-2

Signed-off-by: bizk <[email protected]>

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0b29d5e and 8bc73ee.

Files ignored due to filter (45)

client/v2/go.mod
client/v2/go.sum
go.mod
go.sum
simapp/go.mod
simapp/go.sum
simapp/gomod2nix.toml
tests/go.mod
tests/go.sum
tests/starship/tests/go.mod
tests/starship/tests/go.sum
x/accounts/go.mod
x/accounts/go.sum
x/auth/go.mod
x/auth/go.sum
x/authz/go.mod
x/authz/go.sum
x/bank/go.mod
x/bank/go.sum
x/circuit/go.mod
x/circuit/go.sum
x/distribution/go.mod
x/distribution/go.sum
x/evidence/go.mod
x/evidence/go.sum
x/feegrant/go.mod
x/feegrant/go.sum
x/gov/go.mod
x/gov/go.sum
x/group/go.mod
x/group/go.sum
x/mint/go.mod
x/mint/go.sum
x/nft/go.mod
x/nft/go.sum
x/params/go.mod
x/params/go.sum
x/protocolpool/go.mod
x/protocolpool/go.sum
x/slashing/go.mod
x/slashing/go.sum
x/staking/go.mod
x/staking/go.sum
x/upgrade/go.mod
x/upgrade/go.sum

Files selected for processing (1)

CHANGELOG.md (1 hunks)

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8bc73ee and 9b04f9e.

Files ignored due to filter (45)

client/v2/go.mod
client/v2/go.sum
go.mod
go.sum
simapp/go.mod
simapp/go.sum
simapp/gomod2nix.toml
tests/go.mod
tests/go.sum
tests/starship/tests/go.mod
tests/starship/tests/go.sum
x/accounts/go.mod
x/accounts/go.sum
x/auth/go.mod
x/auth/go.sum
x/authz/go.mod
x/authz/go.sum
x/bank/go.mod
x/bank/go.sum
x/circuit/go.mod
x/circuit/go.sum
x/distribution/go.mod
x/distribution/go.sum
x/evidence/go.mod
x/evidence/go.sum
x/feegrant/go.mod
x/feegrant/go.sum
x/gov/go.mod
x/gov/go.sum
x/group/go.mod
x/group/go.sum
x/mint/go.mod
x/mint/go.sum
x/nft/go.mod
x/nft/go.sum
x/params/go.mod
x/params/go.sum
x/protocolpool/go.mod
x/protocolpool/go.sum
x/slashing/go.mod
x/slashing/go.sum
x/staking/go.mod
x/staking/go.sum
x/upgrade/go.mod
x/upgrade/go.sum

Files selected for processing (1)

CHANGELOG.md (1 hunks)

Additional comments: 1

CHANGELOG.md (1)

67-69: The issues with the changelog entry for pull request feat: extra checks on signatures/pubkeys + check the signature first in antehandle #18194 have already been addressed in previous comments.

Signed-off-by: bizk <[email protected]>

coderabbitai

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 9b04f9e and eeb4fc7.

Files selected for processing (1)

CHANGELOG.md (1 hunks)

coderabbitai · 2023-11-28T20:51:32Z

CHANGELOG.md

-* (crypto | x/auth) [#14372](https://github.com/cosmos/cosmos-sdk/pull/18194) Key checks on signatures antehandle.
+* [#18204](https://github.com/cosmos/cosmos-sdk/pull/18204) Use streaming json parser to parse chain-id from genesis file.
+* (crypto/keys) [#7051](https://github.com/cosmos/cosmos-sdk/issues/7051) Made public key generation constant time on `secp256k1`
+* (crypto | x/auth) [#14372](https://github.com/cosmos/cosmos-sdk/pull/18194) Key checks on signatures antehandle


The changelog entry for pull request #14372 contains a typo or incomplete sentence: "Key checks on signatures antehandle." This should be corrected for clarity and completeness.

tac0turtle · 2023-11-29T09:52:10Z

x/auth/ante/sigverify_test.go

@@ -434,9 +427,8 @@ func TestAnteHandlerChecks(t *testing.T) {
 	// Secp256r1 keys that are not on curve will fail before even doing any operation i.e when trying to get the pubkey
 	testCases := []testCase{
 		{"secp256k1_onCurve", []cryptotypes.PrivKey{priv1}, msgs[0], []uint64{accs[0].GetAccountNumber()}, []uint64{0}, false, true},
-		{"secp256k1_NotOnCurve", []cryptotypes.PrivKey{priv12}, msgs[1], []uint64{accs[1].GetAccountNumber()}, []uint64{1}, true, true},


does this mean the key is always on the curve now or why remove the test case?

The new library does not allow the gneration of keys that are not in the curve, it triggers an error before generating the private key. Even bypassing it and generating a priv key that is not in the curve and assigning it as the key will fail if you try to get the pubkey/address

tac0turtle

utack

testinginprod

utack

tac0turtle · 2023-12-04T15:55:09Z

@bizk could you resolve conflicts so the bot can merge this pr

coderabbitai

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between eeb4fc7 and 2217d1b.

Files ignored due to filter (45)

client/v2/go.mod
client/v2/go.sum
go.mod
go.sum
simapp/go.mod
simapp/go.sum
simapp/gomod2nix.toml
tests/go.mod
tests/go.sum
tests/starship/tests/go.mod
tests/starship/tests/go.sum
x/accounts/go.mod
x/accounts/go.sum
x/auth/go.mod
x/auth/go.sum
x/authz/go.mod
x/authz/go.sum
x/bank/go.mod
x/bank/go.sum
x/circuit/go.mod
x/circuit/go.sum
x/distribution/go.mod
x/distribution/go.sum
x/evidence/go.mod
x/evidence/go.sum
x/feegrant/go.mod
x/feegrant/go.sum
x/gov/go.mod
x/gov/go.sum
x/group/go.mod
x/group/go.sum
x/mint/go.mod
x/mint/go.sum
x/nft/go.mod
x/nft/go.sum
x/params/go.mod
x/params/go.sum
x/protocolpool/go.mod
x/protocolpool/go.sum
x/slashing/go.mod
x/slashing/go.sum
x/staking/go.mod
x/staking/go.sum
x/upgrade/go.mod
x/upgrade/go.sum

Files selected for processing (3)

CHANGELOG.md (1 hunks)
client/keys/add.go (2 hunks)
tests/integration/runtime/query_test.go (1 hunks)

Files skipped from review due to trivial changes (1)

tests/integration/runtime/query_test.go

Additional comments: 4

CHANGELOG.md (2)

69-69: The entry for issue secp256k1: Not constant time #7051 correctly reflects the PR objective of enhancing the secp256k1 public key generation process for security reasons.

68-68: The entry for pull request perf: parse chain-id from big genesis file could be slow #18204 aligns with the summary mentioning the addition of a streaming JSON parser for parsing chain-id from the genesis file.

client/keys/add.go (2)

20-26: The addition of the secp256k1 import aligns with the PR objectives to enhance the secp256k1 public key generation process.

218-234: The changes to create an empty secp256k1 public key and marshal it into JSON align with the PR objectives to use the new secp256k1 implementation.

coderabbitai · 2023-12-04T18:20:09Z

client/keys/add.go

-		tempAny, err := codectypes.NewAnyWithValue(algo.Generate()([]byte{}).PubKey())
+
+		// create an empty seckp256k1 pubkey since it is the key returned by algo Generate function.
+		enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{})


The secp256k1.PubKey{} struct should be initialized with a key of the correct size to prevent potential issues.

- enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{}) + enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{Key: make([]byte, secp256k1.PubKeySize)})

Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{})

enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{Key: make([]byte, secp256k1.PubKeySize)})

coderabbitai · 2023-12-04T18:20:09Z

CHANGELOG.md

@@ -65,6 +65,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (types) [#17670](https://github.com/cosmos/cosmos-sdk/pull/17670) Use `ctx.CometInfo` in place of `ctx.VoteInfos`
 * [#17733](https://github.com/cosmos/cosmos-sdk/pull/17733) Ensure `buf export` exports all proto dependencies
 * (version) [#18063](https://github.com/cosmos/cosmos-sdk/pull/18063) Include additional information in the Info struct. This change enhances the Info struct by adding support for additional information through the ExtraInfo field
+* [#18204](https://github.com/cosmos/cosmos-sdk/pull/18204) Use streaming json parser to parse chain-id from genesis file.
+* (crypto/keys) [#7051](https://github.com/cosmos/cosmos-sdk/issues/7051) Made public key generation constant time on `secp256k1`


The entry for pull request #14372 contains a potential typo: "antehandle" may be intended to be "ante handle" or "antehandler". Please verify the correct terminology and update accordingly.

CHANGELOG.md

* feat: secp256k1 public key constant time (cosmos#18026) Signed-off-by: bizk <[email protected]> * chore: Fixed changelog duplicated items (cosmos#18628) * adr: Un-Ordered Transaction Inclusion (cosmos#18553) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * docs: lint ADR-070 (cosmos#18634) * fix(baseapp)!: postHandler should run regardless of result (cosmos#18627) * docs: fix typos in adr-007-specialization-groups.md (cosmos#18635) * chore: alphabetize labels (cosmos#18640) * docs(x/circuit): add note on ante handler (cosmos#18637) Co-authored-by: Aleksandr Bezobchuk <[email protected]> * fix: telemetry metric label variable (cosmos#18643) * chore: typos fix (cosmos#18642) * refactor(store/v2): updates from integration (cosmos#18633) * build(deps): Bump actions/setup-go from 4 to 5 (cosmos#18647) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(store/v2): snapshot manager (cosmos#18458) * chore(client/v2): fix typos in the README.md (cosmos#18657) * fix(baseapp): protocompat.go gogoproto.Merge does not work with custom types (cosmos#18654) Co-authored-by: unknown unknown <unknown@unknown> * chore: fix several minor typos (cosmos#18660) * chore(tools/confix/cmd): fix typo in view.go (cosmos#18659) * refactor(x/staking): check duplicate addresses in StakeAuthorization's params (cosmos#18655) * feat(accounts): use gogoproto API instead of protov2. (cosmos#18653) Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix(store/commitment/iavl): honor tree.Remove error firstly (cosmos#18651) * build(deps): Bump actions/stale from 8 to 9 (cosmos#18656) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(docs): fix typos & wording in docs (cosmos#18667) * chore: fix several typos. (cosmos#18666) * feat(telemetry): enable `statsd` and `dogstatsd` telemetry sinks (cosmos#18646) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Marko <[email protected]> * feat(store/v2): add SetInitialVersion in SC (cosmos#18665) * feat(client/keys): support display discreetly for `keys add` (cosmos#18663) Co-authored-by: Julien Robert <[email protected]> * ci: add misspell action (cosmos#18671) * chore: typos fix by misspell-fixer (cosmos#18683) Co-authored-by: github-merge-queue <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: add v0.50.2 changelog to main (cosmos#18682) * build(deps): Bump github.com/jhump/protoreflect from 1.15.3 to 1.15.4 in /tests (cosmos#18678) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor(bank): remove .String() calls (cosmos#18175) Co-authored-by: Facundo <[email protected]> * ci: use codespell instead of misspell-fixer (cosmos#18686) Co-authored-by: Marko <[email protected]> * feat(gov): add proposal types and spam votes (cosmos#18532) * feat(accounts): use account number as state prefix for account state (cosmos#18664) Co-authored-by: unknown unknown <unknown@unknown> * chore: typos fixes by cosmos-sdk bot (cosmos#18689) Co-authored-by: github-merge-queue <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat(client/keys): support display discreetly for keys mnemonic (cosmos#18688) * refactor: remove panic usage in keeper methods (cosmos#18636) * ci: rename pr name in misspell job (cosmos#18693) Co-authored-by: Marko <[email protected]> * build(deps): Bump github.com/pelletier/go-toml/v2 from 2.1.0 to 2.1.1 in /tools/confix (cosmos#18702) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(client/keys): support display discreetly for keys export (cosmos#18684) * feat(x/gov): better gov genesis validation (cosmos#18707) --------- Signed-off-by: bizk <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Carlos Santiago Yanzon <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Akaonetwo <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: dreamweaverxyz <[email protected]> Co-authored-by: Pioua <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cool-developer <[email protected]> Co-authored-by: leonarddt05 <[email protected]> Co-authored-by: testinginprod <[email protected]> Co-authored-by: unknown unknown <unknown@unknown> Co-authored-by: Sukey <[email protected]> Co-authored-by: axie <[email protected]> Co-authored-by: Luke Ma <[email protected]> Co-authored-by: Emmanuel T Odeke <[email protected]> Co-authored-by: 0xn4de <[email protected]> Co-authored-by: hattizai <[email protected]> Co-authored-by: Devon Bear <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: Halimao <[email protected]> Co-authored-by: Cosmos SDK <[email protected]> Co-authored-by: github-merge-queue <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Likhita Polavarapu <[email protected]>

bizk added 18 commits August 15, 2023 13:51

added bench test for ed25519 key

c32ca65

added multisig test

d54017c

added hashihg for basic ADR28 address on ed25519

ffc39eb

ran lint fix

1770ef3

merge with master

546dd4e

Refactor tests

5f20b8c

merge

d057344

Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/featu…

71d6a6d

…re/schnorr-1

empty commit to re run actions

f46939e

empty commit to re run actions

c5872a0

Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/featu…

b148bd3

…re/schnorr-2

Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/feat…

e6d38b7

…ure/schnorr-2

added go constant time secp256k1

0655ad1

added constant time pub key implementation and tests

09ce545

Merge branch 'main' of github.com:Zondax/cosmos-sdk into zondax/featu…

2af7ad3

…re/schnorr-2

reverted changes and deleted optimization to make code fully constant

1b18936

removed tidy code

f0e1c06

Added changelog.md

ae93077

github-actions bot added the C:x/staking label Oct 9, 2023

bizk added 7 commits October 9, 2023 19:26

cleanup

4ebca65

Signed-off-by: bizk <[email protected]>

cleanup

b6a0494

Signed-off-by: bizk <[email protected]>

go lint fix

e5f98c5

gofumpt files

0586436

added fix on deprecated package

6416425

suggestion by linter

8898092

ran gci

70c604c

alexanderbez changed the title ~~feat: secp256k1 public key constan time~~ feat: secp256k1 public key constant time Oct 10, 2023

bizk added 2 commits October 10, 2023 17:16

gci fix

5e96e6b

returned file back to how it was

6a70994

github-actions bot removed the C:x/staking label Oct 10, 2023

coderabbitai bot reviewed Nov 21, 2023

View reviewed changes

bizk requested a review from tac0turtle November 21, 2023 19:35

Merge branch 'main' into feature/secp256k1constant

9b04f9e

github-actions bot removed the C:Hubl Tool: Hubl label Nov 28, 2023

coderabbitai bot reviewed Nov 28, 2023

View reviewed changes

fixed changelog

eeb4fc7

Signed-off-by: bizk <[email protected]>

coderabbitai bot reviewed Nov 28, 2023

View reviewed changes

tac0turtle reviewed Nov 29, 2023

View reviewed changes

tac0turtle approved these changes Nov 29, 2023

View reviewed changes

tac0turtle assigned tac0turtle and testinginprod Nov 29, 2023

bizk requested review from JulianToledano and julienrbrt November 29, 2023 14:16

Merge branch 'main' into feature/secp256k1constant

7989412

testinginprod approved these changes Dec 4, 2023

View reviewed changes

tac0turtle disabled auto-merge December 4, 2023 15:54

Merge branch 'main' into feature/secp256k1constant

2217d1b

coderabbitai bot reviewed Dec 4, 2023

View reviewed changes

bizk removed the C:x/accounts label Dec 4, 2023

removed unused import

0c101fa

bizk enabled auto-merge December 4, 2023 19:00

bizk added this pull request to the merge queue Dec 4, 2023

Merged via the queue into cosmos:main with commit b6f9c70 Dec 4, 2023
53 of 56 checks passed

bizk deleted the feature/secp256k1constant branch December 4, 2023 19:06

julienrbrt reviewed Dec 4, 2023

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

bizk mentioned this pull request Dec 5, 2023

chore: Fixed changelog duplicated items #18628

Merged

12 tasks

marcello33 mentioned this pull request Jan 22, 2024

Upstream fetch (#2) #19163

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: secp256k1 public key constant time #18026

feat: secp256k1 public key constant time #18026

bizk commented Oct 9, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot Nov 28, 2023

tac0turtle Nov 29, 2023

bizk Nov 29, 2023

tac0turtle left a comment

testinginprod left a comment

tac0turtle commented Dec 4, 2023

coderabbitai bot left a comment

coderabbitai bot Dec 4, 2023

coderabbitai bot Dec 4, 2023

	enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{})
	enotySecpPubKey, err := codectypes.NewAnyWithValue(&secp256k1.PubKey{Key: make([]byte, secp256k1.PubKeySize)})

feat: secp256k1 public key constant time #18026

feat: secp256k1 public key constant time #18026

Conversation

bizk commented Oct 9, 2023 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Nov 28, 2023

Choose a reason for hiding this comment

tac0turtle Nov 29, 2023

Choose a reason for hiding this comment

bizk Nov 29, 2023

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

testinginprod left a comment

Choose a reason for hiding this comment

tac0turtle commented Dec 4, 2023

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Dec 4, 2023

Choose a reason for hiding this comment

coderabbitai bot Dec 4, 2023

Choose a reason for hiding this comment

bizk commented Oct 9, 2023 •

edited by coderabbitai bot

Loading