-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 2.3.2 #12
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Cool! Feel free to add yourself as a mantainer if you like! |
Regarding the test failures, I am afraid not all patches are backport that can be removed. I wanted to eventually contribute them upstream, but it was not super clear to me how OGRECave/ogre-next#232 and OGRECave/ogre-next#259 was going, so I decided to do it later (i.e. I forgot to do it, sorry!). Some related (hidden) comments can be found in conda-forge/staged-recipes#19384 . |
Looking a bit in the failures, one problem is that upstream Ogre-Next still does not install .pc files on Windows. |
Yep, I have another local patch for it. Keeping this draft until we can get it all sorted/ported. |
Signed-off-by: Michael Carroll <[email protected]>
I dumped patches from here, which I think will be slightly easier to maintain: https://github.com/gazebo-forks/ogre-next/tree/gazebo/v2-3 |
Any news? |
There is no 2.3.2 release for ogre-next . |
What version is the next release? |
The latest is 2.3.1 and is packaged in conda-forge (see https://github.com/OGRECave/ogre-next/releases), the next one is 2.3.2 or some other version number > 2.3.1, probably ogre-next mantainers will decide that. |
You mean when ogre-next will be releasing this PR will become relevant? Thank you for your details answer. |
Yes, this PR is just a preparation for the next release of ogre-next.
Yes, it is possible more modifications will be necessary, that is why the PR is in draft. |
Replaced by #18 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)I have upstream-ed several of these patches. Once the 2.3.2 tag is added, this should be just about ready to go.