Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogre-next v2.3.3 #18

Merged
merged 17 commits into from
Apr 8, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #17

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6764542783, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro traversaro mentioned this pull request Apr 7, 2024
3 tasks
@traversaro
Copy link
Contributor

traversaro commented Apr 7, 2024

I build on top of the work of @mjcarroll in #12 .

@traversaro
Copy link
Contributor

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor

macOS builds fail with:

2024-04-07T20:28:54.0312820Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/src/OgreAnimable.cpp:28:
2024-04-07T20:28:54.0313530Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgreStableHeaders.h:44:
2024-04-07T20:28:54.0314240Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgreCommon.h:32:
2024-04-07T20:28:54.0314940Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgrePrerequisites.h:461:
2024-04-07T20:28:54.0315650Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgreStdHeaders.h:79:
2024-04-07T20:28:54.0316260Z In file included from /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:60:
2024-04-07T20:28:54.0317380Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFPropertyList.h:69:9: error: non-defining declaration of enumeration with a fixed underlying type is only permitted as a standalone declaration; missing list of enumerators? [-Welaborated-enum-base]
2024-04-07T20:28:54.0318060Z typedef CF_ENUM(CFIndex, CFPropertyListFormat) {
2024-04-07T20:28:54.0318430Z         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-04-07T20:28:54.0319190Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:169:55: note: expanded from macro 'CF_ENUM'
2024-04-07T20:28:54.0319810Z #define CF_ENUM(...) __CF_ENUM_GET_MACRO(__VA_ARGS__, __CF_NAMED_ENUM, __CF_ANON_ENUM, )(__VA_ARGS__)
2024-04-07T20:28:54.0320230Z                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-04-07T20:28:54.0321390Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:134:48: note: expanded from macro '__CF_ENUM_GET_MACRO'
2024-04-07T20:28:54.0321970Z #define __CF_ENUM_GET_MACRO(_1, _2, NAME, ...) NAME
2024-04-07T20:28:54.0322310Z                                                ^
2024-04-07T20:28:54.0323350Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:142:75: note: expanded from macro '__CF_NAMED_ENUM'
2024-04-07T20:28:54.0323970Z #define __CF_NAMED_ENUM(_type, _name)     enum __CF_ENUM_ATTRIBUTES _name : _type _name; enum _name : _type
2024-04-07T20:28:54.0324350Z                                                                           ^~~~~~~
2024-04-07T20:28:54.0324850Z fatal error: too many errors emitted, stopping now [-ferror-limit=]

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits April 8, 2024 07:09
@traversaro
Copy link
Contributor

macOS builds fail with:

2024-04-07T20:28:54.0312820Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/src/OgreAnimable.cpp:28:
2024-04-07T20:28:54.0313530Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgreStableHeaders.h:44:
2024-04-07T20:28:54.0314240Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgreCommon.h:32:
2024-04-07T20:28:54.0314940Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgrePrerequisites.h:461:
2024-04-07T20:28:54.0315650Z In file included from /Users/runner/miniforge3/conda-bld/ogre-next_1712521500670/work/OgreMain/include/OgreStdHeaders.h:79:
2024-04-07T20:28:54.0316260Z In file included from /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:60:
2024-04-07T20:28:54.0317380Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFPropertyList.h:69:9: error: non-defining declaration of enumeration with a fixed underlying type is only permitted as a standalone declaration; missing list of enumerators? [-Welaborated-enum-base]
2024-04-07T20:28:54.0318060Z typedef CF_ENUM(CFIndex, CFPropertyListFormat) {
2024-04-07T20:28:54.0318430Z         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-04-07T20:28:54.0319190Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:169:55: note: expanded from macro 'CF_ENUM'
2024-04-07T20:28:54.0319810Z #define CF_ENUM(...) __CF_ENUM_GET_MACRO(__VA_ARGS__, __CF_NAMED_ENUM, __CF_ANON_ENUM, )(__VA_ARGS__)
2024-04-07T20:28:54.0320230Z                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2024-04-07T20:28:54.0321390Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:134:48: note: expanded from macro '__CF_ENUM_GET_MACRO'
2024-04-07T20:28:54.0321970Z #define __CF_ENUM_GET_MACRO(_1, _2, NAME, ...) NAME
2024-04-07T20:28:54.0322310Z                                                ^
2024-04-07T20:28:54.0323350Z /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:142:75: note: expanded from macro '__CF_NAMED_ENUM'
2024-04-07T20:28:54.0323970Z #define __CF_NAMED_ENUM(_type, _name)     enum __CF_ENUM_ATTRIBUTES _name : _type _name; enum _name : _type
2024-04-07T20:28:54.0324350Z                                                                           ^~~~~~~
2024-04-07T20:28:54.0324850Z fatal error: too many errors emitted, stopping now [-ferror-limit=]

The solution seems to set the -Wno-elaborated-enum-base compilation option, surprised that this is not hitting more packages, see https://github.com/search?q=org%3Aconda-forge%20Wno-elaborated-enum-base&type=code and llvm/llvm-project#48757 .

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor

For some reason only on osx the installation location of the RenderSystem plugins is incorrect, i.e. $PREFIX\lib instead of $PREFIX\lib\OGRE-Next.

@traversaro
Copy link
Contributor

For some reason only on osx the installation location of the RenderSystem plugins is incorrect, i.e. $PREFIX\lib instead of $PREFIX\lib\OGRE-Next.

Fixed in 886d983 .

@mjcarroll mjcarroll mentioned this pull request Apr 8, 2024
4 tasks
@traversaro
Copy link
Contributor

@mjcaroll any comment on this?

recipe/build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny misspelling. Otherwise LGTM!

Co-authored-by: Michael Carroll <[email protected]>
@traversaro traversaro merged commit 92dbfcb into conda-forge:main Apr 8, 2024
1 of 8 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 2.3.3_h5edf5f branch April 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants