-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ogre-next #19384
Add ogre-next #19384
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ogre-next:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
038690b
to
396e7b7
Compare
Even if the CI is still finishing, @wolfv @Tobias-Fischer this is necessary to actually have a working Gazebo (formerly known as Ignition) packages with ROS2, as ROS2 RViz2 uses Ogre 1.12, and Gazebo does not work with Ogre 1.12 (see RoboStack/ros-galactic#104 for a problem generated by the fact that we do not have ogre-next). As you are mantainers of ogre feedstock, please reply if you like to be mantainers of ogre-next as well, thanks! |
I'll give this one a miss re becoming maintainer.. |
Thanks for working in this! I'm happy to be added as a maintainer. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/ogre-next:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Done in b87742c . |
Let me know if you think this is ready. Happy to merge! |
The PR is ready. |
Thanks @wolfv! |
This PR adds
ogre-next
, a C++ 3D graphics engine .First of all, it is important to clarify a bit the relation between
ogre
andogre-next
. What is now ogre-next started as ogre 2, with substutiantial changes w.r.t. to ogre 1. However, many users of ogre never migrated to ogre 2, so they continued to use and mantain ogre 1. As a consequence, at some point ogre 2 renamed itself to ogre-next, while ogre 1 continued to exits as ogre, also bumping its major version number, going from 1.13 to 13 (see https://github.com/conda-forge/ogre-feedstock).As a consequence, it is quite important to permit to ogre and ogre-next to be installed side-by-side in the same environment, as for example in the robotics world RViz2 (a visualizer) uses ogre, while the new generation of Gazebo (formerly known as Ignition) uses ogre-next . The upstream ogre-next still needs to complete its support to be installable side-by-side with ogre (see OGRECave/ogre-next#232), so in this PR we patched the project to be side-by-side installable with ogre as was done in Debian/Ubuntu packacing (see https://salsa.debian.org/ogre-team/ogre-next/-/blob/a27f70cd8c6b82e3fc207fefe557b43bc49634b4/debian/README.Debian).
For an overview of the existing differences between Ogre and Ogre Next, see https://www.ogre3d.org/about/what-version-to-choose .
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).