Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subdomain-revoked.pem. Addresses #404. #410

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

lgarron
Copy link
Collaborator

@lgarron lgarron commented Oct 5, 2019

Since the previous certificate was, well... revoked, we can't get a cert with the same private key. We'll have to add the new key to the revocation lists before this works.

Since the previous certificate was, well... revoked, we can't get a cert with the same private key. We'll have to add the new key to the revocation lists before this works.
@lgarron lgarron requested a review from christhompson October 5, 2019 23:33
@lgarron
Copy link
Collaborator Author

lgarron commented Oct 5, 2019

@ericlaw1979, any chance you could get this key/cert added to Microsoft's CRL? :-D

Copy link
Collaborator

@christhompson christhompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll get a CL up to update the SPKI in Chromium soon (and maybe push it in the CRLSet component to get better coverage).

@christhompson christhompson merged commit 6879ba2 into master Oct 9, 2019
@christhompson
Copy link
Collaborator

This is now deployed. I've landed CLs to update the preloaded blocklist in Chrome and the CRLSet component. It may take ~1 day of the CRLSet to push out and reach most Chrome installs, so for now revoked.badssl.com may appear marked "Secure" in Chrome.

@lgarron lgarron deleted the revoked branch October 9, 2019 21:44
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 9, 2019
We're updating the certificate for revoked.badssl.com (the previous
certificate expired on 2019/09/11) in
chromium/badssl.com#410, and we should likewise
update the certificate/SPKI in the blocklist.

We are also updating the manually added list in CRLSet.

Change-Id: I95c50250cc0139cf82dac214c785efa2704ea599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846018
Reviewed-by: Adam Langley <[email protected]>
Commit-Queue: Christopher Thompson <[email protected]>
Cr-Commit-Position: refs/heads/master@{#704364}
april added a commit to april/badssl.com that referenced this pull request Jan 16, 2020
* 'master' of https://github.com/chromium/badssl.com: (175 commits)
  Add (known|blocked)-interception.badssl.com tests (chromium#423)
  Update `10000-sans`. (chromium#420)
  Rename subdomain-no-sct.crt to subdomain-no-sct.pem
  Add missing common in sets.js
  Mark DHE as bad or dubious (chromium#398)
  Add `no-sct.badssl.com`. Addresses chromium#275. (chromium#409)
  Update chain for `subdomain-1000-sans.pem`. Closes chromium#383. (chromium#408)
  Update `subdomain-revoked.pem`. Addresses chromium#404. (chromium#410)
  Add page with 🔒 in title (chromium#388)
  Explicitly send the self-signed root for untrusted-root (chromium#397)
  [web-payment] Print API return values and exceptions in the footer. (chromium#392)
  Tweak formatting for client cert passwords (chromium#385)
  Add descriptions to the dashboard sections. (chromium#371)
  Remove hyphens from dh domain pages. Fixes chromium#379 (chromium#380)
  Add incomplete chain description in footer. (chromium#366)
  Fix redirect port for `tls-v1-2`. (chromium#362)
  Export environment variables in the Makefile (chromium#355)
  Flip cert chain order for wildcard-rsa4096.pem (chromium#353)
  Add EV certificate (chromium#352)
  Update subdomain-extended-validation.conf
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants