Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect port for tls-v1-2. #362

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Fix redirect port for tls-v1-2. #362

merged 1 commit into from
Aug 27, 2018

Conversation

lgarron
Copy link
Collaborator

@lgarron lgarron commented Aug 26, 2018

Tahnks to @ExE-Boss for noticing.

@lgarron lgarron requested a review from christhompson August 26, 2018 20:28
Copy link

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

Copy link
Collaborator

@christhompson christhompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- hadn't run into this due to only testing it via the homepage. LGTM.

@lgarron lgarron merged commit 1e5238d into master Aug 27, 2018
@lgarron lgarron deleted the tls-v1-2-port branch August 27, 2018 17:18
@lgarron
Copy link
Collaborator Author

lgarron commented Aug 27, 2018

Thanks, @ExE-Boss and @christhompson!

@christhompson
Copy link
Collaborator

The fix should be live now.

april added a commit to april/badssl.com that referenced this pull request Jan 16, 2020
* 'master' of https://github.com/chromium/badssl.com: (175 commits)
  Add (known|blocked)-interception.badssl.com tests (chromium#423)
  Update `10000-sans`. (chromium#420)
  Rename subdomain-no-sct.crt to subdomain-no-sct.pem
  Add missing common in sets.js
  Mark DHE as bad or dubious (chromium#398)
  Add `no-sct.badssl.com`. Addresses chromium#275. (chromium#409)
  Update chain for `subdomain-1000-sans.pem`. Closes chromium#383. (chromium#408)
  Update `subdomain-revoked.pem`. Addresses chromium#404. (chromium#410)
  Add page with 🔒 in title (chromium#388)
  Explicitly send the self-signed root for untrusted-root (chromium#397)
  [web-payment] Print API return values and exceptions in the footer. (chromium#392)
  Tweak formatting for client cert passwords (chromium#385)
  Add descriptions to the dashboard sections. (chromium#371)
  Remove hyphens from dh domain pages. Fixes chromium#379 (chromium#380)
  Add incomplete chain description in footer. (chromium#366)
  Fix redirect port for `tls-v1-2`. (chromium#362)
  Export environment variables in the Makefile (chromium#355)
  Flip cert chain order for wildcard-rsa4096.pem (chromium#353)
  Add EV certificate (chromium#352)
  Update subdomain-extended-validation.conf
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants