Print API return values and exceptions in the footer. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier debugging on mobile devices, print the API return values and exception messages in the footer area of the page.
|
I made an attempt at what I think is a better way of including log messages in this test case (and might be useful for other test cases where exposing logs visibly for mobile testing is useful), but couldn't push changes to this PR directly. Here's the diff based off of this PR: 793837a Roughly, this moves the log to be default-hidden and adds a toggle to the test case content area. It also styles the log to be a bit less obtrusive. WDYT? |
|
Excellent! That's even better than what I wrote :-D
…On Fri, Jun 21, 2019 at 1:57 PM Chris Thompson ***@***.***> wrote:
I made an attempt at what I think is a better way of including log
messages in this test case (and might be useful for other test cases where
exposing logs visibly for mobile testing is useful), but couldn't push
changes to this PR directly. Here's the diff based off of this PR: 793837a
<793837a>
Roughly, this moves the log to be default-hidden and adds a toggle to the
test case content area. It also styles the log to be a bit less obtrusive.
WDYT?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#392?email_source=notifications&email_token=AAH3EGK2RMYO7Y5HG6KEZ43P3UI7ZA5CNFSM4H2SGRDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJE6GA#issuecomment-504516376>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAH3EGIVE3QTXHXIS3LXKF3P3UI7ZANCNFSM4H2SGRDA>
.
|
|
@christhompson : I've merged your proposed changes to this pull request. Git preserved your authorship, too! |
april
added a commit
to april/badssl.com
that referenced
this pull request
Jan 16, 2020
* 'master' of https://github.com/chromium/badssl.com: (175 commits) Add (known|blocked)-interception.badssl.com tests (chromium#423) Update `10000-sans`. (chromium#420) Rename subdomain-no-sct.crt to subdomain-no-sct.pem Add missing common in sets.js Mark DHE as bad or dubious (chromium#398) Add `no-sct.badssl.com`. Addresses chromium#275. (chromium#409) Update chain for `subdomain-1000-sans.pem`. Closes chromium#383. (chromium#408) Update `subdomain-revoked.pem`. Addresses chromium#404. (chromium#410) Add page with 🔒 in title (chromium#388) Explicitly send the self-signed root for untrusted-root (chromium#397) [web-payment] Print API return values and exceptions in the footer. (chromium#392) Tweak formatting for client cert passwords (chromium#385) Add descriptions to the dashboard sections. (chromium#371) Remove hyphens from dh domain pages. Fixes chromium#379 (chromium#380) Add incomplete chain description in footer. (chromium#366) Fix redirect port for `tls-v1-2`. (chromium#362) Export environment variables in the Makefile (chromium#355) Flip cert chain order for wildcard-rsa4096.pem (chromium#353) Add EV certificate (chromium#352) Update subdomain-extended-validation.conf ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier debugging on mobile devices, print the API return values and
exception messages in the footer area of the page.