-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CI tool and drop xshell dependency. #13279
base: main
Are you sure you want to change the base?
Conversation
I'm sorry if the description isn't very coherent. It's very late here. I'm going to sleep. I'll fix everything tomorrow. |
I created Brezak#2 with just a few small refactors. I think it's possible to still use a trait instead of having inconsistent |
This is work for a future PR but several commands could be flags on other commands. For example both the test-check and cfg-check commands could be flags on the compile-check command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs work, but I think that's for future PRs. Looks like a good first start!
This bumps all the `mod` declarations to the top, all the `pub use` declarations second, and all the private `use` declarations last.
More thorough explanation by Brezak here: #2 (comment)
This reverts commit 751dd5f.
c24ce17
to
e312441
Compare
e312441
to
17c667e
Compare
This is part 2 of my attempt at improving the errors CI spits out. See part 1 (#13187) for the action plan.
Problem
The current structure of the CI tool means we can't really execute anything other than shell scripts.
Solution
PreparedCommand
struct andPrepare
trait.Testing
cargo run -p ci -- compile-check
.Probably should have waited for #13187 to merge. But oh well. Might as well get some feedback on my approach here.
Most of the command code isn't very human friendly. It was written to be copy-pastable as writing all that boiler plate by hand
would have turned my brain to mush.
cc @BD103