-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check docs.rs metadata in CI #13275
Check docs.rs metadata in CI #13275
Conversation
We re trying to avoid shellscripts to be cross platform. Could you add it to the ci rust script? |
Example error output (source): |
Not easily right now. Our current When we do finish it, this will be one of the first things ported. ( |
Speaking of which: #13279. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the current limitations regarding the ci
tool, this seems alright to me from a quick glance. Nice documentation :)
Closing due to inactivity. If someone want to adopt this, feel free! |
Objective
[package.metadata.docs.rs]
table of all crates that use them, as well as in CI (see Add adoc-generate
command to theci
tool #13173 for related work).Solution
check_docsrs_metadata.sh
, which verifies that all public crates have the correct metadata usingcargo metadata
.bevy
crate.bevy
crate from checks.Testing
./tools/check_docsrs_metadata.sh
locally. It should either pass or give an error message for all invalid crates.Further Questions
Cargo.toml
is modified (thinkdependencies.yml
), or only in the merge queue?Changelog
[package.metadata.docs.rs]
for all public crates is now verified in CI.