Small improvements to nicer CI errors #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps all the `mod` declarations to the top, all the `pub use` declarations second, and all the private `use` declarations last.
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Brezak
requested changes
May 8, 2024
More thorough explanation by Brezak here: Brezak#2 (comment)
This reverts commit 751dd5f.
Brezak
pushed a commit
that referenced
this pull request
May 9, 2024
More thorough explanation by Brezak here: #2 (comment)
Brezak
pushed a commit
that referenced
this pull request
Jul 11, 2024
…3906) # Objective - Second part of bevyengine#13900 - based on bevyengine#13905 ## Solution - check_dir_light_mesh_visibility defers setting the entity's `ViewVisibility `so that Bevy can schedule it to run in parallel with `check_point_light_mesh_visibility`. - Reduce HashMap lookups for directional light checking as much as possible - Use `par_iter `to parallelize the checking process within each system. --------- Co-authored-by: Kristoffer Søholm <[email protected]>
Brezak
pushed a commit
that referenced
this pull request
Dec 24, 2024
More thorough explanation by Brezak here: #2 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors a few bits of code, but does not change any logic. :)
I recommend viewing the changes one commit at a time, it's easier to digest what's happening!