[bevy_ui/layout] Update tests to get GlobalTransform properly #12802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2024
NthTensor
added
A-UI
StrikeForceZero
force-pushed
the
dev/bevy_ui/update_layout_tests
branch
from
d03ba9f to
be7e6a2
Compare
|
@StrikeForceZero I think these diffs will look nicer if you rebase on top of main now, since #12801 was merged. |
Remove the need to manually update GlobalTransform in bevy_ui/layout tests
StrikeForceZero
force-pushed
the
dev/bevy_ui/update_layout_tests
branch
from
e89ac04 to
9946b8f
Compare
james7132
approved these changes
Apr 3, 2024
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
…gine#12802) This is 2 of 5 iterative PR's that affect bevy_ui/layout - [x] Blocked by bevyengine#12801 [Diff to parent PR](https://github.com/StrikeForceZero/bevy/compare/dev/bevy_ui/breakup_layout_mod..dev/bevy_ui/update_layout_tests) --- # Objective - Update a test in bevy_ui/layout to use the proper way to get an up to date `GlobalTransform` ## Solution - Adds `sync_simple_transforms`, and `propagate_transforms` to the test schedule in bevy_ui/layout ---
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
… for UiSurface (#12803) This is 3 of 5 iterative PR's that affect bevy_ui/layout - [x] Blocked by #12801 - [x] Blocked by #12802 --- # Objective - Add tests to `UiSurface` - Add missing asserts in `_assert_send_sync_ui_surface_impl_safe` - Add missing Debug field print for `camera_entity_to_taffy` ## Solution - Adds tests to `UiSurface` - Adds missing asserts in `_assert_send_sync_ui_surface_impl_safe` - Adds missing impl Debug field print for `camera_entity_to_taffy` --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 2 of 5 iterative PR's that affect bevy_ui/layout
Diff to parent PR
Objective
GlobalTransformSolution
sync_simple_transforms, andpropagate_transformsto the test schedule in bevy_ui/layout