[bevy_ui/layout] Extract UiSurface to its own file #12801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
StrikeForceZero
changed the title
This was referenced Mar 30, 2024
NthTensor
added
A-UI
StrikeForceZero
force-pushed
the
dev/bevy_ui/breakup_layout_mod
branch
from
fd718d3 to
042b21c
Compare
james7132
approved these changes
Mar 30, 2024
afonsolage
approved these changes
Mar 31, 2024
pablo-lua
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
This is 2 of 5 iterative PR's that affect bevy_ui/layout - [x] Blocked by #12801 [Diff to parent PR](https://github.com/StrikeForceZero/bevy/compare/dev/bevy_ui/breakup_layout_mod..dev/bevy_ui/update_layout_tests) --- # Objective - Update a test in bevy_ui/layout to use the proper way to get an up to date `GlobalTransform` ## Solution - Adds `sync_simple_transforms`, and `propagate_transforms` to the test schedule in bevy_ui/layout ---
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
This is 1 of 5 iterative PR's that affect bevy_ui/layout --- # Objective - Extract `UiSurface` into its own file to make diffs in future PR's easier to digest ## Solution - Moved `UiSurface` to its own file
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
…gine#12802) This is 2 of 5 iterative PR's that affect bevy_ui/layout - [x] Blocked by bevyengine#12801 [Diff to parent PR](https://github.com/StrikeForceZero/bevy/compare/dev/bevy_ui/breakup_layout_mod..dev/bevy_ui/update_layout_tests) --- # Objective - Update a test in bevy_ui/layout to use the proper way to get an up to date `GlobalTransform` ## Solution - Adds `sync_simple_transforms`, and `propagate_transforms` to the test schedule in bevy_ui/layout ---
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
… for UiSurface (#12803) This is 3 of 5 iterative PR's that affect bevy_ui/layout - [x] Blocked by #12801 - [x] Blocked by #12802 --- # Objective - Add tests to `UiSurface` - Add missing asserts in `_assert_send_sync_ui_surface_impl_safe` - Add missing Debug field print for `camera_entity_to_taffy` ## Solution - Adds tests to `UiSurface` - Adds missing asserts in `_assert_send_sync_ui_surface_impl_safe` - Adds missing impl Debug field print for `camera_entity_to_taffy` --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 1 of 5 iterative PR's that affect bevy_ui/layout
Objective
UiSurfaceinto its own file to make diffs in future PR's easier to digestSolution
UiSurfaceto its own file