New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several small fixes for previous PR #383 #385

Merged

restingbull merged 1 commit into bazelbuild:master from jongerrish:fixes_for_option_rules

Nov 11, 2020

Contributor

jongerrish commented Nov 11, 2020

Fixes required to use kt_kotlinc_options and kt_javac_options


          Several small fixes for previous PR bazelbuild#383

7dd02a2

jongerrish requested review from cgruber, djwhang, jin, restingbull and timpeut as code owners

November 11, 2020 00:45

Collaborator

Bencodes commented Nov 11, 2020

Just opened up the same pull request here #386 but also exposed kt_kotlinc_options and kt_javac_options so that we can override the default opts.

restingbull approved these changes

View reviewed changes

restingbull merged commit 83a26dc into bazelbuild:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

restingbull restingbull approved these changes

cgruber Awaiting requested review from cgruber cgruber is a code owner

djwhang Awaiting requested review from djwhang

jin Awaiting requested review from jin

timpeut Awaiting requested review from timpeut

Labels

None yet