Expose kt_kotlinc_options and kt_javac_options #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
|
can anyone merge this Pull Request as Custom toolchain cannot be set |
Bencodes
force-pushed
the
expose-kotlinc-javac-opts
branch
from
d20d6e3 to
44c10d9
Compare
restingbull
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed in this PR
kt_kotlinc_optionsandkt_javac_optionsare being exposed bykotlin/kotlin.bzlso that we can optionally override the default kotlinc and javac options