-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option rules for kotlinc and javac. #383
Add option rules for kotlinc and javac. #383
Conversation
3f63e22
to
af780b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, just what we need!
@@ -106,28 +106,30 @@ message JvmCompilationTask { | |||
} | |||
|
|||
message Inputs { | |||
// The full classpath | |||
// The full classpath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird formatting. Why did the comments indent, but the decl didn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine and straightforward. It's pretty limited, with no arbitrary flags passable, which I assume is the intended design philosophy. I think this is the right start. We can carefully add more options where reasonable.
There's areas of work and design around use-cases where people want per-target options (very typically annotation processing options), but this is fine to start, and doesn't preclude any further work that I can see.
Annotation processing is a slippery slope. While java happily allows arbitrary flags whenever, it's not a maintainable approach outside of a mono-repo. I suspect we'd be better off wrapping annotation processor arguments with the plugin rather that attaching them per library. Discovery on that (when removing the processor, for example) is painful. |
No description provided.