Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf] Load C++,Java,Protobuf rules from Starlark #9001

Closed
wants to merge 1 commit into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Jul 28, 2019

@jin jin added the team-Rules-Server Issues for serverside rules included with Bazel label Jul 28, 2019
@Yannic
Copy link
Contributor Author

Yannic commented Jul 28, 2019

Depends on #9002

@Yannic Yannic force-pushed the merge_proto_6432_and_6445 branch from 7dc5c8f to 137cc78 Compare August 6, 2019 17:18
Copy link
Contributor Author

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lberki This change is ready for review. ptal.

@@ -24,9 +27,6 @@ config_setting(
load(":protobuf.bzl", "py_proto_library")
load(":compiler_config_setting.bzl", "create_compiler_config_setting")

# Needed for #9006. Hopefully a future upstream version will include this line.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent a PR to Protobuf to fix this, so I don't think this comment is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. You're awesome :)

Copy link
Contributor

@lberki lberki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me merge this!

@lberki
Copy link
Contributor

lberki commented Aug 7, 2019

Merged as deeeba3 so I'm closing this.

@lberki lberki closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-Server Issues for serverside rules included with Bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants