[bazel] Add fixes for --incompatible_load_{cc,java,proto}_rules_from_bzl (Part 2) #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
reviewed
Jul 26, 2019
protobuf_deps.bzl
Outdated
| @@ -5,6 +5,14 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | |||
| def protobuf_deps(): | |||
| """Loads common dependencies needed to compile the protobuf library.""" | |||
|
|
|||
| if not native.existing_rule("zlib"): | |||
There was a problem hiding this comment.
Should this be "bazel_skylib" here instead of "zlib"?
Yannic
force-pushed
the
fix_incompatible_load_part_2
branch
from
7b54c9a to
14228d5
Compare
Yannic
commented
Jul 26, 2019
protobuf_deps.bzl
Outdated
| @@ -5,6 +5,14 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | |||
| def protobuf_deps(): | |||
| """Loads common dependencies needed to compile the protobuf library.""" | |||
|
|
|||
| if not native.existing_rule("zlib"): | |||
|
I think to make the tests happy you will have to remove |
…bzl (Part 2)
This change adds the required loads to examples and zlib.
For full compatibility with --incompatible_load_{cc,java,proto}_rules_from_bzl,
we will need to roll gtest to a newer version.
Yannic
force-pushed
the
fix_incompatible_load_part_2
branch
from
14228d5 to
7911b18
Compare
|
Thanks for saving me time to figure that out! |
Yannic
added a commit
to Yannic/bazel
that referenced
this pull request
Jul 28, 2019
Yannic
added a commit
to Yannic/bazel
that referenced
this pull request
Aug 6, 2019
Yannic
added a commit
to Yannic/bazel
that referenced
this pull request
Aug 6, 2019
Yannic
added a commit
to Yannic/bazel
that referenced
this pull request
Aug 6, 2019
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the required loads to examples and zlib. Sorry for missing them in the first PR.
For full compatibility with --incompatible_load_{cc,java,proto}_rules_from_bzl,
we will need to roll gtest to a newer version.