Fix some tests in preparation for --incompatible_load_proto_rules_from_bzl #9002
Conversation
…oto_rules_from_bzl
| @@ -465,6 +465,22 @@ http_archive( | |||
| EOF | |||
| } | |||
|
|
|||
| function add_rules_java_to_workspace() { | |||
There was a problem hiding this comment.
Why does rules_java need to be added?
There was a problem hiding this comment.
rules_java will be a dependency of protobuf after #9001.
There was a problem hiding this comment.
That raises quite a few questions wrt. dependency management, but all of them are out of scope for this pull request and let's try to fix problems one at a time. Approved!
|
(It appears that a lot of tests are still broken. Is this ready for review?) |
irengrig
added
the
team-Rules-Server
Yannic
changed the title
| @@ -465,6 +465,22 @@ http_archive( | |||
| EOF | |||
| } | |||
|
|
|||
| function add_rules_java_to_workspace() { | |||
There was a problem hiding this comment.
rules_java will be a dependency of protobuf after #9001.
|
FYI: I got into some trouble with keeping our internal integration tests green with this change. Stay tuned! |
|
Update: I'll revert the changes in |
No description provided.