Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests after upgrading Windows image #13816

Closed
philwo opened this issue Aug 8, 2021 · 5 comments
Closed

Fix failing tests after upgrading Windows image #13816

philwo opened this issue Aug 8, 2021 · 5 comments
Assignees
@meteorcloudy
Labels
area-Windows Windows-specific issues and feature requests P0 This is an emergency and more important than other current work. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@philwo
Copy link
Member

philwo commented Aug 8, 2021

The following tests fail after I upgraded our Windows image on CI:

I have sent a fix for python_version_test and will disable the other three temporarily.

The difference between the old Windows image and the new one is:
@philwo philwo added type: bug P0 This is an emergency and more important than other current work. (Assignee required) area-Windows Windows-specific issues and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Aug 8, 2021
@philwo
Copy link
Member Author

philwo commented Aug 8, 2021

@meteorcloudy If you have time, could you help me figure out how to fix them on Monday? 😊

@meteorcloudy
Copy link
Member

Sure, looking into them!

bazel-io pushed a commit that referenced this issue Aug 9, 2021
@philwo @copybara-github
Temporarily disable failing tests on Windows.
077cb6f 
Tracked in #13816.

PiperOrigin-RevId: 389572724
@meteorcloudy
Copy link
Member

Ha, looks like grep somehow failed to match Windows line endings, let me check why this is happening..

@philwo
Copy link
Member Author

philwo commented Aug 9, 2021

Maybe a bug or update in MSYS2? 🤔

Also I remembered one more thing that changed - I upgraded the base image from Windows 10 build 1909 to build 20H2.

@meteorcloudy
Copy link
Member

msys2/MSYS2-packages#2163 (comment)

Turned out this is an incompatible change in grep after upgrading grep to 3.5 in MSYS. We'll fix this by removing the line ending match in those tests.

@philwo philwo mentioned this issue Aug 9, 2021
Open
meteorcloudy added a commit to meteorcloudy/bazel that referenced this issue Aug 13, 2021
@meteorcloudy
Removing line ending matches in tests to be compatible on Windows
f4e1036 
grep was upgraded to 3.5 after updating MSYS on Winodws VM, which no longer matches CRLF line endings with `$`.

Fixes bazelbuild#13816

RELNOTES: None
PiperOrigin-RevId: 389600750
@meteorcloudy meteorcloudy mentioned this issue Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
area-Windows Windows-specific issues and feature requests P0 This is an emergency and more important than other current work. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philwo @meteorcloudy