Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep: Update to 3.5 #2163

Closed
wants to merge 1 commit into from
Closed

Conversation

jannick0
Copy link
Contributor

  • grep/PKGBUILD:
    • update version and hash
    • remove references to outdated and obsolete patches
    • build binary in separate directory
  • grep/{grep-2.23-msys2.patch,grep-3.0-2.patch}: remove files

* grep/PKGBUILD:
  - update version and hash
  - remove references to outdated and obsolete patches
  - build binary in separate directory
* grep/{grep-2.23-msys2.patch,grep-3.0-2.patch}: remove files
@Biswa96
Copy link
Member

Biswa96 commented Sep 28, 2020

Are those patches in upstream repository? If yes then a commit message with that upstream commit link would be helpful.

@Alexpux
Copy link
Member

Alexpux commented Sep 28, 2020

It not possible to update grep for MSYS2 as upstream drop support for crlf. So I hope it will not be merged

@lazka lazka added the needinfo label Sep 28, 2020
@Alexpux
Copy link
Member

Alexpux commented Sep 29, 2020

@jannick0
Copy link
Contributor Author

@Alexpux I fully agree that grep is a central piece to MSYS2. Yesterday I was not aware of this severe issue.

  • The documentation (changed in the commit you are pointing to - thanks) does not read very clear to me (highlilghts from me):

Under MS-Windows, use binary I/O when reading and writing files other
than the user's terminal
, so that all input bytes are read and written
as-is. This overrides the default behavior where @command{grep}
follows the operating system's advice whether to use binary or text
I/O.

  • grep-3.0-2.src.patch cannot be reverted in the source of grep-3.5, since the target source file is removed meanwhile. So the much feared change does not show up in the source anymore.
  • I am confused about grep's expected vs actual CRLF/LF handling now: What should grep do and what shouldn't it do (test cases?) with respect to -U, CRLF/LF in shell MSYS2/MINGW64/MINGW32,..., which input to grep?

Or am I missing something here?

@Alexpux
Copy link
Member

Alexpux commented Sep 29, 2020

@jannick0 look at #1353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants