[Cherrypick 4.2.0] Fix Windows tests for 4.2.0rc3 after Windows image update #13846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Python 3.9.
Overloading the "re" module causes weird errors on our new Windows VM image, probably because Python itself uses it for some purpose now. I noticed this in our Bazel CI testing area, so the new image is not yet live.
Let's try to use a module that's less core to Python, but still in the standard library - I picked "mailbox" after looking at the list of standard library modules.
Here's an example log from the failing test on the new image:
```
** test_source_file_does_not_override_standard_library *************************
[...]
Error processing line 1 of C:\Python3\lib\site-packages\protobuf-3.17.3-py3.9-nspkg.pth:
Fatal Python error: init_import_site: Failed to import the site module
Python runtime state: initialized
Traceback (most recent call last):
File "C:\Python3\lib\site.py", line 169, in addpackage
exec(line)
File "<string>", line 1, in <module>
File "C:\Python3\lib\importlib\util.py", line 2, in <module>
from . import abc
File "C:\Python3\lib\importlib\abc.py", line 17, in <module>
from typing import Protocol, runtime_checkable
File "C:\Python3\lib\typing.py", line 2203, in <module>
Pattern = _alias(stdlib_re.Pattern, 1)
AttributeError: module 're' has no attribute 'Pattern'
```
PiperOrigin-RevId: 389572773
grep was upgraded to 3.5 after updating MSYS on Winodws VM, which no longer matches CRLF line endings with `$`. Fixes bazelbuild#13816 RELNOTES: None PiperOrigin-RevId: 389600750
meteorcloudy
changed the title
katre
changed the title
katre
approved these changes
Aug 13, 2021
|
Merged to release-4.2.0-patches (not release-4.2.0rc3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick request for 4.2.0 (#13558).
Context: #13816