Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility audit #1385

Merged
merged 9 commits into from
Jul 4, 2019
Merged

Accessibility audit #1385

merged 9 commits into from
Jul 4, 2019

Conversation

alexreardon
Copy link
Collaborator

@alexreardon alexreardon commented Jun 27, 2019

Fixes:

Keyboard usage during a drag #1288

It was found by @seancurtis the most consistent way to get good keyboard usage was to not be in the browse mode for screen readers. So we now state in the lift message that users should not use browse mode when dragging

Lift announcements #865

@seancurtis has converted our usage of aria-roledescription to aria-labelledby={ElementId} and pointed it to a visually hidden element (see useLiftInstruction()). This seemed to give good lift instructions.

Still to do /cc @stacylondon

  • Test that aria-labelledby works on your hardware setups. Feel free to pivot strategy if you find a better approach. We tested on NVDA and JAWS and all seemed well
  • Add Google lighthouse build to repo

Other things that need to be done, but don't feel like you need to

  • Write small test for useLiftInstruction() (Will do later)
  • Update screen-reader.md lift instruction docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants