Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Keyboard usage during a drag #1288
It was found by @seancurtis the most consistent way to get good keyboard usage was to not be in the browse mode for screen readers. So we now state in the lift message that users should not use browse mode when dragging
Lift announcements #865
@seancurtis has converted our usage of
aria-roledescription
toaria-labelledby={ElementId}
and pointed it to a visually hidden element (see useLiftInstruction()
). This seemed to give good lift instructions.Still to do /cc @stacylondon
aria-labelledby
works on your hardware setups. Feel free to pivot strategy if you find a better approach. We tested on NVDA and JAWS and all seemed wellOther things that need to be done, but don't feel like you need to
useLiftInstruction()
(Will do later)