-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to move away from aria-roledescription #865
Comments
Thanks for checking this out. We have previously run tests with various screen readers and everything worked as expected /cc @seancurtis. I find that running the examples in an iframe often messes with things. Try running the examples out of an iframe: (add .iframe.html before the query) |
Hi Alex, Thanks for the quick reply. It's worth noting though that even though the drag and drop functionality works on the iframe link you provided, JAWS 2018 provides no information from the aria-roledescription. The entire drag and drop process is silent. I will test on IE (Which JAWS prefers) and NVDA/Firefox later today. |
Thank you. This is a tricky space to get right. Any suggestions welcome
…On Wed, 24 Oct 2018 at 6:48 pm, benjaland ***@***.***> wrote:
Hi Alex,
Thanks for the quick reply.
I tested the link you provided and you're right, the drag n drop
functionality works with the spacebar on the machine I'm currently on - and
doesn't work on the original storybook link I had used. (Chrome
69.0.3497.100 (Official Build) (64-bit) (cohort: Stable))
It's worth noting though that even on the iframe link you provided, JAWS
2018 provides no information from the aria-roledescription.
I will test on IE (Which JAWS prefers) and NVDA/Firefox later today.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#865 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFN7XZedVAUz6LzIyeCrLjQgdn6qQTbks5uoBs2gaJpZM4X1iFK>
.
|
We currently use aria-roledescription as we found it had the most
consistent announcement. But open to other mechanisms for the initial
announce!
…On Wed, 24 Oct 2018 at 6:52 pm, Alex Reardon ***@***.***> wrote:
Thank you. This is a tricky space to get right. Any suggestions welcome
On Wed, 24 Oct 2018 at 6:48 pm, benjaland ***@***.***>
wrote:
> Hi Alex,
>
> Thanks for the quick reply.
> I tested the link you provided and you're right, the drag n drop
> functionality works with the spacebar on the machine I'm currently on - and
> doesn't work on the original storybook link I had used. (Chrome
> 69.0.3497.100 (Official Build) (64-bit) (cohort: Stable))
>
> It's worth noting though that even on the iframe link you provided, JAWS
> 2018 provides no information from the aria-roledescription.
>
> I will test on IE (Which JAWS prefers) and NVDA/Firefox later today.
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> <#865 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACFN7XZedVAUz6LzIyeCrLjQgdn6qQTbks5uoBs2gaJpZM4X1iFK>
> .
>
|
Wanted to add additional information: I ran into a similar issue when I run the example in Chrome. However, it works fine in Edge--this might be a browser support issue. |
@benjaland Did you encounter the same issues with JAWS or NVDA when running on Edge? |
This is not being ignored. I am working with a number of organisations to find a good path forward. The issue with JAWs and nvda is the "virtual cursor". If you disable that then everything is fine. Both of those screen readers are intercepting a spacebar press and sending a click event. We are hopefully also getting in touch with some a developer from nvda to see what we can do on our end, or if there is something they can do on theirs 👍 |
#1238 has some fantastic detail for reference. Any suggestions on an alternative? |
Is just a plain old |
Not understanding the title change. Is that the root cause with the "virtual cursor" issue? I am also seeing this issue, both locally in my own site and on one of the examples that doesn't have hyperlinks, since those it just navigates to: https://react-beautiful-dnd.netlify.com/?path=/story/accessibility--single-list. There running NVDA prevents reordering of the list, but disabling it makes everything work fine. |
Fixed as a part of #1385 |
Bug or feature request?
Bug
Expected behavior
With JAWS or NVDA screen reader running, pressing the space bar when the draggable component is focused initiates the dragging process.
Using the storybook as an example
https://react-beautiful-dnd.netlify.com/?selectedKind=single%20vertical%20list&selectedStory=basic&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel
This has also been seen "in the wild" with other implementations.
Actual behavior
With JAWS or NVDA screen reader running, pressing the space bar actives the hyperlink functionality, taking the user in this instance to the Adventure Time Wiki page.
Steps to reproduce
What version of
React
are you using?Your instance/storybook.
What version of
react-beautiful-dnd
are you running?Your instance/storybook.
What browser are you using?
Chrome 65.0.3325.146 (Official Build) (64-bit)
Demo
https://react-beautiful-dnd.netlify.com/?selectedKind=single%20vertical%20list&selectedStory=basic&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel
The text was updated successfully, but these errors were encountered: