add a11y auditing #1386
Merged
add a11y auditing #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
reviewed
Jul 3, 2019
.gitignore
Outdated
| # test reports | ||
| test-reports/ | ||
| # a11y reports | ||
| a11y-audit.json |
There was a problem hiding this comment.
can we put this with our other reports?
alexreardon
reviewed
Jul 3, 2019
.circleci/config.yml
Outdated
|
|
||
| - run: | ||
| name: Accessibility Audit | ||
| command: node browser-test-harness.js yarn test:accessibility |
There was a problem hiding this comment.
can we get the json output added as an artifact?
stacylondon
force-pushed
the
slondon/add-a11y-auditing
branch
from
6803bae to
bb2bf71
Compare
alexreardon
reviewed
Jul 3, 2019
package.json
Outdated
| @@ -33,6 +33,8 @@ | |||
| "prettier_target": "*.{js,jsx,md,json} src/**/*.{js,jsx,md,json} test/**/*.{js,jsx,md,json} docs/**/*.{js,jsx,md,json} stories/**/*.{js,jsx,md,json} cypress/**/*.{js,jsx,md,json}" | |||
| }, | |||
| "scripts": { | |||
| "test:accessibility": "lighthouse http://localhost:9002/iframe.html?id=single-vertical-list--basic --chrome-flags='--headless' --output=json --output-path=./test-reports/lighthouse/a11y-audit.json && yarn test:accessibility:report", | |||
| "test:accessibility:report": "node a11y-audit-parse.js", | |||
There was a problem hiding this comment.
does this need to be a separate step?
There was a problem hiding this comment.
At first I was thinking I might have test:accessibility and test:accessibility:ci and then they could share that common step but now there is only a need for test:accessibility so I'll consolidate and just have the one NPM script for this.
There was a problem hiding this comment.
Done; just a single step now.
stacylondon
force-pushed
the
slondon/add-a11y-auditing
branch
from
bb2bf71 to
eb52c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.