-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 Bugs/Improvements - Subtitle won't refresh when changing tracks / Load External Subtitle By Default? #34
Comments
Could you please share some metadata about the video? My player requires use of SRT/ASS subtitles in order to make text selection work and the issue that you're experiencing may be related to PGS subtitles, which are unsupported and cannot possibly be converted to text without OCR. |
On the second suggestion, I don't intend to extend support to multiple external subtitles as it complicates things as is with scoped storage and external subtitle issues caused by higher Android SDKs - a single external subtitle is enough. It is also a prescriptive decision - users aren't supposed to be referring back to native language subtitles in the first place. If you mean to auto-load external subtitles (with subtitles only the same name as the current video filename), that's already performed and it may be issues with the file picker if it doesn't work. |
General Video Audio Text #1 Text #2 Text #3 Text #4 Text #5 Text #6 Text #7 Text #8 Text #9 Text #10 Text #11 Text #12 Text #13 Text #14 Text #15 Text selection works, it's just unable to changed from Arabic over to simplified Chinese. Here's a clip of me using the app - https://streamable.com/wo098e |
What is your method for changing the file manager? Is there a recommended alternative one? I literally just hit Player and it opens. Here's a clip: https://streamable.com/gbd20o I edited my previous post and added a clip for the previous issue as well. |
Seems this is a complicated issue that would be a bit hard to explain. In order to generate the transcript and enable me to pull text into the program, the subtitles are actually extracted from the video file when the video is loaded. I hard set the maximum number of subtitles to be extracted to 10, and your video has way over this amount, that's why simplified Chinese at the very end could not be selected. It is impossible for me to pull subtitle data from the VLC player I use. To be able to have the entire subtitle from start to finish, I have to perform file operations on the video file in order to be able to display subtitles. When you select "Simplified Chinese", it's supposed to select an extracted subtitle file, and it didn't exist since extraction was not performed to that index. External subtitles are loaded if no subtitle menu options are lit in the menu. If you were selecting something like |
The primary issue of subtitles above a certain index not being selectable has been resolved in 0.25.8. I understand that some users are unable to import subtitles by default due to scoped storage issues. There is nothing I can do about this and this is a consequence of the direction that Android has simply decided to take with their files policy. For this reason, I cannot at this stage implement load by default for the devices that are already implementing this aggressive change. This feature would require me to be able to obtain the absolute URI path of the picked video which I simply cannot get on a certain SDK level. I am very frustrated about this. The only remedy for this on higher SDK levels is to use the scoped storage branch I've provided and pick external subtitle files manually. If there are any other issues, feel free to re-open. With that, I'm closing this issue. |
Wouldn't this mean that if a show has softsubs, it wouldn't load the external subtitle file? So, I would highly suggest that your app be changed so that it loads an external subtitle file if possible. I think it's important for people to be able to go right from 1 episode to the next, and not have to remux their encodes in order to use their app, as downloading the raws for shows has yet to become the standard. I really hope you can fix this up, because this app is very exciting. Thank you. |
It does auto-load an external subtitle file, as I've described. There are Android file API issues that get in the way with this behavior which causes an issue for some number of users, but the functionality is there -- and works up for most users up to Android 10, myself included. All you have to do is rename the subtitle file to have the same name as the video file. Android 11 (and some minority of Android 10 users) is where users have to manually import, again because of scoped storage. Only the video file is cached and I do not have access to the raw URI path in order to get the subtitles as well. I consider this a very critical issue considering that sooner or later users will ditch their phones for newer devices and everyone will have to put up with scoped storage. A fix might have to be resorting to MediaStore and newer Android SAF methods in order to pick the video file, and then get the similarly named subtitle path by the raw URI. I need to investigate my options, and it is likely that I am at the mercy of what alternatives I have given that I use Flutter and hence am limited in the ways to instance a |
Aah, I took a break and I misunderstood what you meant. I get what you mean now. I just tried it on my Xiaomi along with my Galaxy with the scopedstorage version of the 0.25.8-beta. Still not autoloading the external subs, but that other issue was indeed fixed as you said. |
Hello,
One issue I'm having is on a show with multiple subtitle tracks, it won't actually change to the selected subtitle track. It loads the first subtitle in alphabetical order that's embedded on a .mkv, so Arabic in my example. I try to change it to Chinese Simplified, and after I select the new subtitle, it won't reload the subtitles for the video, so it's stuck just displaying Arabic.
My second thing is a suggestion: Use a fuzzysearch to open related subtitle files and add them into the subtitle list - this would help dealing with lots of shows with external subtitles.
example:
Are You OK Episode 01 iQiyi 1920x1080.mp4
Are You OK Episode 01 iQiyi 1920x1080.en.srt
Are You OK Episode 01 iQiyi 1920x1080.zh-CN.srt
This is the common naming convention, where all subtitles include the full filename, and append a language code after a period (.)
I think this is related to the File Picker, but I'm not sure how to override that on Android...
I hope to see these fixes or a clarification with this app, if no one else is experiencing the issue.
Vlad
The text was updated successfully, but these errors were encountered: