Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitle remains visible until the next one is displayed #14

Closed
mikavilpas opened this issue Apr 24, 2021 · 4 comments
Closed

Subtitle remains visible until the next one is displayed #14

mikavilpas opened this issue Apr 24, 2021 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@mikavilpas
Copy link

In some cases, a subtitle line lasts for a couple of seconds, say, and then it should end according to the transcript, followed by a break of some time before the next subtitle line.

So

  • sub1 should be shown for 5s
  • there should be no subtitle visible for 5s
  • a new subtitle line should be shown

In my case the second step is skipped, meaning the first line is not hidden.

@mikavilpas
Copy link
Author

Just verified this doesn't make exporting that sub line any longer (audio wise) than what the transcript says. So maybe this is not that bad.

@arianneorpilla
Copy link
Owner

arianneorpilla commented Apr 24, 2021

I consider this a feature and design choice, not a bug. Yes, there are instances where there may be something like an opening playing and the subtitle will be left playing, but this solves many nuances with subtitles being too hard to catch or the very slightest bits of text too hard to rewind for.

@arianneorpilla
Copy link
Owner

Found an elegant solution for this that should hide the subtitle while keeping it as the current context (if the subtitle end time is past, the widget hides -- internally, the previous subtitle is still kept so export and seek backs should still be the subtitle, just hidden from view). Should be included in the next version.

@arianneorpilla arianneorpilla self-assigned this Apr 24, 2021
@arianneorpilla arianneorpilla added bug Something isn't working enhancement New feature or request labels Apr 24, 2021
@arianneorpilla
Copy link
Owner

arianneorpilla commented Apr 24, 2021

I have implemented this feature in 0.13.4.

See the relevant line in the release notes:

  • Subtitle widget will now be hidden from view if the current player position is not within a 100ms range of the last subtitle viewed

With that, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants