Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't confirm ending playback when video has ended #7

Closed
mikavilpas opened this issue Apr 23, 2021 · 1 comment
Closed

Don't confirm ending playback when video has ended #7

mikavilpas opened this issue Apr 23, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mikavilpas
Copy link

I figured I'd open some issues that seem like low hanging fruit.

When the video has ended and I navigate back to leave it, I'm still asked if I want to leave.

Kind of makes sense but idk if it would be nice to just leave without asking in this case.

@arianneorpilla arianneorpilla added the enhancement New feature or request label Apr 23, 2021
@arianneorpilla arianneorpilla self-assigned this Apr 23, 2021
@arianneorpilla
Copy link
Owner

I have implemented this feature in 0.13.1.

See the relevant line in the release notes:

  • The player will no longer show the 'End Playback' message if the video has already ended*

With that, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants