Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when selecting a subtitle file #13

Closed
mikavilpas opened this issue Apr 24, 2021 · 6 comments
Closed

Crash when selecting a subtitle file #13

mikavilpas opened this issue Apr 24, 2021 · 6 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@mikavilpas
Copy link

I have an anime episode and subtitles for that episode as an .ass file. When I select "Load External Subtitles" from the player menu and select that .ass file, the player crashes every time.

I seem to be able to work around this crash if I first select "no subtitles" and then select the .ass file.

I suspect this may have something to do with the fact that the video file has an embedded English subtitle that is selected by default.

I'm using the latest version, 0.13.1 beta.

I realize this is not a lot to go by, so let me know what I could provide to help investigating this.

@mikavilpas
Copy link
Author

It seems the workaround I described is not that reliable... A better workaround seems to be to start playing a different file and then switch back to the first file.

Looks like it tries to load the subs that have the same name dna the extension but they are empty (the transcript is empty) but when I manually load the subs, they work fine.

This is a bit messy, maybe multiple issues occurring at the same time.

@arianneorpilla arianneorpilla self-assigned this Apr 24, 2021
@arianneorpilla arianneorpilla added bug Something isn't working question Further information is requested labels Apr 24, 2021
@arianneorpilla
Copy link
Owner

I have a guess at the cause but to confirm the issue, please attach the subtitle file so I can have a look at it.

Cheers.

@mikavilpas
Copy link
Author

Here is one of the files I have had problems with,

[Doki] Usagi Drop - 02 (1920x1080 Hi10P BD FLAC) [94E10265].ass.zip

@arianneorpilla
Copy link
Owner

arianneorpilla commented Apr 25, 2021

I have implemented a fix for this in 0.13.5.

The issue was that the code for loading the default subtitles assumed that the format was in SRT. Therefore, any ASS files could not be loaded by default -- Conversely, when importing them, the file was converted appropriately.

I also fixed an issue with subtitles where timestamps may show in the transcript as text as artifacts.

See the relevant lines in the release notes:

  • Fixed an issue with default ASS/SRT subtitles with the same filename as the video file were loaded as a raw string SRT
  • Fixed an SRT parsing issue which showed timestamps in the transcript where the line after the timestamp showed up as blank

I am closing this issue. If the problem persists, please do report and I will reopen this issue.

@mikavilpas
Copy link
Author

Unfortunately this is still occurring for me.

Before the new version, I would see the embedded English ass subs as well as the Japanese ass subs that are in a file with the same name as the video.

After the fix, I only see the English subs in the subtitle selection menu.

In both cases, loading the Japanese subs as an external sub will crash or close the application.

@arianneorpilla
Copy link
Owner

After investigations, I believe that this issue is an extremely low-end device-specific issue. I can't do much about it except to suggest sourcing the video and subtitles elsewhere -- the video and subtitle in question appear to load in multiple devices and emulators I have tested with.

If ever more information arises, I may look over this again but for now I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants