Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace instanbul w/ nyc #100

Merged
merged 3 commits into from
Nov 10, 2019
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 8, 2019

Motivation and Context

instanbul is no longer maintained and we use nyc across all other repos.

Closes #72

Description

Drop instanbul
Added nyc & configs

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 4.0.0 milestone Nov 8, 2019
@erisu erisu requested a review from raphinesse November 8, 2019 02:10
.gitignore Outdated Show resolved Hide resolved
.npmignore Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@erisu erisu force-pushed the v4-instanbul-to-nyc branch from 2fe94c1 to 6a16dc5 Compare November 8, 2019 14:55
@erisu erisu requested a review from raphinesse November 8, 2019 15:01
@codecov-io
Copy link

codecov-io commented Nov 10, 2019

Codecov Report

Merging #100 into master will decrease coverage by 1.7%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   87.98%   86.28%   -1.71%     
==========================================
  Files          19       21       +2     
  Lines        1748     1560     -188     
  Branches      358        0     -358     
==========================================
- Hits         1538     1346     -192     
- Misses        210      214       +4
Impacted Files Coverage Δ
src/util/plist-helpers.js 78.94% <0%> (-2.45%) ⬇️
src/PluginInfo/PluginInfo.js 81.59% <0%> (-1.83%) ⬇️
src/CordovaError/CordovaError.js 86.95% <0%> (-1.51%) ⬇️
src/ConfigChanges/ConfigFile.js 87.39% <0%> (-1.18%) ⬇️
src/PluginInfo/PluginInfoProvider.js 83.87% <0%> (-0.98%) ⬇️
src/CordovaCheck.js 86.66% <0%> (-0.84%) ⬇️
src/ActionStack.js 93.54% <0%> (-0.74%) ⬇️
src/FileUpdater.js 85.38% <0%> (-0.63%) ⬇️
src/PluginManager.js 91.83% <0%> (-0.62%) ⬇️
src/events.js 95% <0%> (-0.46%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79ef47...d70fd6f. Read the comment docs.

@raphinesse raphinesse merged commit c76fc60 into apache:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants