Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate from istanbul to nyc coverage tool #72

Closed
wants to merge 1 commit into from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 11, 2019

Platforms affected

All

Motivation and Context

It is desired to use a supported coverage tool that will be updated and should be less likely affected by security issues in the future.

Description

See title: migrate from istanbul to nyc coverage tool, in a similar fashion to the updates in apache/cordova-lib#637, apache/cordova-lib#783, and apache/cordova-lib#784

Testing

  • npm run cover succeeds on supported Node.js versions 6, 8, and 10

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@brodycj brodycj requested review from dpogue, raphinesse and erisu June 11, 2019 23:09
@dpogue
Copy link
Member

dpogue commented Jun 12, 2019

Actually, it looks like codecov isn't able to find the coverage file anymore...

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to take a look how I setup nyc on other repos for example Cordova Electron.

https://github.com/apache/cordova-electron

The package.json contains the nyc reporting configurations and the script that passes in the test configuration file.

This should still create the coverage directory and still be in the .gitignored.

@brodycj brodycj changed the title Migrate from istanbul to nyc coverage tool [WIP] Migrate from istanbul to nyc coverage tool Jun 12, 2019
@brodycj
Copy link
Contributor Author

brodycj commented Jun 12, 2019

Thanks guys, marked as WIP for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants