Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve npm ignore list #104

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 8, 2019

Motivation and Context

Decrease production package size

Description

Drop From Package

  • all dot file and folders with .* (.github, .travis.yml, .eslintrc.yml, etc...)
    • .github/
    • .travis.yml
    • .eslintrc.yml
    • .eslintignore
    • .ratignore
  • appveyor.yml

BEFORE
npm notice package size: 41.5 kB
npm notice unpacked size: 179.4 kB
npm notice total files: 34

AFTER
npm notice package size: 39.1 kB
npm notice unpacked size: 173.8 kB
npm notice total files: 24

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

Drop From Package
* all dot file and folders with .* (.github, .travis.yml, .eslintrc.yml, etc...)
  * .github/
  * .travis.yml
  * .eslintrc.yml
  * .eslintignore
  * .ratignore
* appveyor.yml

== PACKAGE REPORT ==
* BEFORE
npm notice package size:  41.5 kB
npm notice unpacked size: 179.4 kB
npm notice total files:   34

* AFTER
npm notice package size:  39.1 kB
npm notice unpacked size: 173.8 kB
npm notice total files:   24
@erisu erisu added this to the 4.0.0 milestone Nov 8, 2019
@erisu erisu requested a review from raphinesse November 8, 2019 02:31
@dpogue
Copy link
Member

dpogue commented Nov 8, 2019

Just out of curiosity, does this interfere at all with coho's ability to verify archives and licenses if those files are missing from the archive?

@erisu
Copy link
Member Author

erisu commented Nov 8, 2019

It should not have any affect.

The license/header checking process is performed on the git repo and not the content of the npm package. For the releaser, at this stage, the package is not even created yet.

The sha512 and asc file is created against the package not the repo content.

Here is an example on how the asc file is created for the release vote. (E.g. below is for recent cordova-eslint release)

gpg --armor --detach-sig --output ./cordova-eslint-config-1.0.0.tgz.asc ./cordova-eslint-config-1.0.0.tgz

Here is an example on how the sha512 is created for the release vote. (E.g. below is for the recent cordova-eslint release)

gpg --print-md SHA512 ./cordova-eslint-config-1.0.0.tgz

If you were to take the sha512 of the git repo content and package, yes, they would be different, but how the release does it is against the package (tgz).

^^ ABOVE covers the person performing the release ^^

For a person who is voting on the release,

The coho verify-archive is only using the asc and sha512 file that was used against the tgz package.

The coho verify-tags is only compares the git commit hash ref that is given with the tag name.

Example for the Cordova ESLint recent release

$ git rev-parse 918d6a9c90
918d6a9c904c3da7feedbed4063fe4671afcf971

@raphinesse raphinesse mentioned this pull request Nov 8, 2019
1 task
@raphinesse raphinesse merged commit 2fb32fe into apache:master Nov 10, 2019
raphinesse added a commit to erisu/cordova-common that referenced this pull request Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants