-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE #25102
[Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE #25102
Conversation
…che#25101) * Fix truncate copyjob when WRITE_TRUNCATE in BigQuery batch load
R: @johnjcasey |
Codecov Report
@@ Coverage Diff @@
## release-2.45.0 #25102 +/- ##
==================================================
- Coverage 73.13% 73.13% -0.01%
==================================================
Files 735 735
Lines 98151 98153 +2
==================================================
- Hits 71782 71781 -1
- Misses 25006 25009 +3
Partials 1363 1363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Spotless PreCommit |
Run Whitespace PreCommit |
LGTM |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
btw white space is expected to fail on release branch; the fix is #25055 not in release-2.45.0 we can cherry pick it if wants to get it green (though trivial) |
... in BigQuery batch load
cherry-pick #25101 into release-2.45.0
justification: this is a bug fix of data loss; the original fix, aibeit a typo prevented it took effect, was in 2.45.0.
Fixes #24535
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.