Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE #25102

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 20, 2023

... in BigQuery batch load

cherry-pick #25101 into release-2.45.0
justification: this is a bug fix of data loss; the original fix, aibeit a typo prevented it took effect, was in 2.45.0.

Fixes #24535

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

…che#25101)

* Fix truncate copyjob when WRITE_TRUNCATE in BigQuery batch load
@Abacn Abacn changed the base branch from master to release-2.45.0 January 20, 2023 18:36
@Abacn
Copy link
Contributor Author

Abacn commented Jan 20, 2023

R: @johnjcasey

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #25102 (2885a8c) into release-2.45.0 (622f380) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release-2.45.0   #25102      +/-   ##
==================================================
- Coverage           73.13%   73.13%   -0.01%     
==================================================
  Files                 735      735              
  Lines               98151    98153       +2     
==================================================
- Hits                71782    71781       -1     
- Misses              25006    25009       +3     
  Partials             1363     1363              
Flag Coverage Δ
python 82.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/python/apache_beam/io/gcp/bigquery_file_loads.py 87.38% <100.00%> (+0.22%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (-1.34%) ⬇️
...eam/runners/portability/fn_api_runner/execution.py 92.49% <0.00%> (-0.64%) ⬇️
sdks/python/apache_beam/transforms/combiners.py 93.05% <0.00%> (-0.39%) ⬇️
sdks/python/apache_beam/typehints/typehints.py 92.88% <0.00%> (-0.17%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.24%) ⬆️
sdks/python/apache_beam/pipeline.py 92.42% <0.00%> (+0.29%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johnjcasey
Copy link
Contributor

Run Spotless PreCommit

@johnjcasey
Copy link
Contributor

Run Whitespace PreCommit

@johnjcasey
Copy link
Contributor

LGTM

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Jan 20, 2023

btw white space is expected to fail on release branch; the fix is #25055 not in release-2.45.0 we can cherry pick it if wants to get it green (though trivial)

@johnjcasey johnjcasey merged commit 7e59b52 into apache:release-2.45.0 Jan 23, 2023
@Abacn Abacn deleted the cherrypick-truncatefix branch January 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants