-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix truncate copy job when WRITE_TRUNCATE in BigQuery batch load #25101
Conversation
R: @robertwb We may need another cherry-pick because the original fix, marked as 2.45.0 milestone, did not take effect. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
We may need to update the comment, as this did not impact the 2.44 release |
Codecov Report
@@ Coverage Diff @@
## master #25101 +/- ##
=======================================
Coverage 73.12% 73.12%
=======================================
Files 735 735
Lines 98153 98161 +8
=======================================
+ Hits 71776 71785 +9
+ Misses 25013 25012 -1
Partials 1364 1364
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@johnjcasey it impacts 2.44.0, and also seen in previous releases. Will try to track since when it is introduced. It is reported as early as 2.41.0 possibly a long hiden bug but only get exposed as people migrating their batch job to Dataflow runner v2 |
Run Python_Examples PreCommit |
…che#25101) * Fix truncate copyjob when WRITE_TRUNCATE in BigQuery batch load
) (#25102) * Fix truncate copyjob when WRITE_TRUNCATE in BigQuery batch load
Fixes #24535
Due to a typo the original fix did not take effect. Fixed and added a test.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.